1807036 - Refactor the search engine verification code to make exceptions clearer

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

When an engine is set as default, we additionally record a hash to verify that it has been saved correctly and not modified.

In bug 1805883 we had to fix an issue where we missed an exception to the verification code which was due to it being handled within the body of the search service, rather than where we handle the getting/setting the verifications in SearchSettings.

I think we should consider moving the isAppProvided check into the verification function, and additionally making it so that migrateEngineIds can also share the functionality in some manner (e.g. via an additional function).

Comment 1

[Mark Banner (:standard8)]

We might also want to consider how the documentation works in the file, e.g. if we need to call this out in the setter docs as well.

Comment 2

[Mandy Cheang [:mcheang][she/her] - Away Oct 5– Nov 9]

Attachment: Bug 1807036 - move isAppProvided check for hash verification out of search service and into search settings. r=standard8!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17f6906b8e55
move isAppProvided check for hash verification out of search service and into search settings. r=Standard8

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/17f6906b8e55