1807127 - Changing the device's name appears to not work even though it apparently does

Status: VERIFIED FIXED

(Firefox for Android :: Accounts and Sync, defect, P2)

Description

[Christian Sadilek [:csadilek]]

From github: https://github.com/mozilla-mobile/fenix/issues/17100.

Steps to reproduce

1. Go to Settings and sign in with a valid account.
2. Tap on Device name and rename your device.
3. Tap on OK, then check if the new name is saved.

Expected behavior

The edited name of the device is saved without issues.

Actual behavior

The edited name isn't saved.
If repeating steps 2 & 3, the user can see the edited name in the edit field, but when it is saved, the name doesn't change.

Device information

• Android device: all
• Fenix version: Beta 85.0.0-beta.1
• Not reproducible on 12/17 Nightly, nor on RC 84.1.1

<img src="https://user-images.githubusercontent.com/40694158/102497589-7d2d1f00-4081-11eb-92b7-fb8af2af5385.gif" width="300" height="550" />

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

I just tried this and the device name does appear to be changed in FxA, it's just not reflected as being changed on the menu - it does change at some point though, just not immediately. If you go back into the menu to edit the name again, it continues to show the old name, not the new name. So it really looks like it didn't work, but actually does.

Comment 3

[Mira Lobontiu (Android QA)]

Attachment: device name.mp4

This issue still reproduces on all Firefox versions: Nightly 113.0a1 from 3/14, Beta 112.0b1, and RC 111.0.
Tested with Sony Xperia Z5 Premium (Android 7.1.1).

Comment 4

[Vlad Dreghici [:vdreghici]]

I have investigated this ticket for a while. I have also attached a video in which the problem is shown both on android device and on web browser, and you can see how in the first attempts the name changes on Android UI then reverts, while on the web browser the new name is actually saved, but in the last one, the name is saved correctly in Android. It looks like the issue here is that after the listener here is notified that the name is changed, in onChangeDeviceName, syncDeviceName is called, which launches this coroutine. While this runs, the name is already updated in UI and pref, but after it is finished, setDeviceName is called which fetches all devices in order to refresh them, sometimes fetching the old name of the current device, leading to it reverting in the UI. The issue seems to be fixed by moving the action dispatch from onChangeDeviceName to the inside of the coroutine making the name actually change after a small delay. You can check this in the PR attached. If this was a solution to consider, we will need feedback from UX on how to notice the user of the "loading" while the name is being changed.

Comment 5

[Vlad Dreghici [:vdreghici]]

Attachment: Untitled(3).mp4

Comment 6

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1807127 - Update Sync Device name after refreshing fxa devices (#1576)

Comment 7

[Vlad Dreghici [:vdreghici]]

Tagging this as needs-ux, since there is a slight delay after pressing ok and the name actually showing up in the UI. I came up with a solution, but I want to double-check and make sure this would be ok. You can check the video here and the solution for the delay that I reached to here.

Comment 8

[Joe M [:jmahon]]

That solution looks pretty elegant to me, Vlad. I'm OK making an executive decision on behalf of the UX team to approve this visual change.

Comment 9

[BMO Github Automation]

Authored by https://github.com/DreVla
https://github.com/mozilla-mobile/firefox-android/commit/c729f8e46dfddda396a08e238c5061d1639701c7
[main] Bug 1807127 - Update Sync Device name after refreshing fxa devices

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 11

[Lorand Janos]

Managed to reproduce on the latest Beta build (118.0b3) with a Huawei P20 (android 10) device.
Verified as fixed on the latest Nightly build (119.0a1 from 2023-09-01).
The changed device name is saved successfully.
Device used: Google Pixel 7 (Android 14)
Marking the ticket as verified for 119.

Comment 12

[Lorand Janos]

Attachment: az_recorder_20230901_094617.mp4

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:vdreghici, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox118 to wontfix.

For more information, please visit BugBot documentation.

Comment 14

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1807127 - Update Sync Device name after refreshing fxa devices (backport #1576) (#3617)

Comment 15

[Vlad Dreghici [:vdreghici]]

Comment on attachment 9352852 [details] [review]
[mozilla-mobile/firefox-android] Bug 1807127 - Update Sync Device name after refreshing fxa devices (backport #1576) (#3617)

Beta/Release Uplift Approval Request

• User impact if declined: Changing the name on the sync screen would cause confusion as it would appear like it doesn't work, even thought it does.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Same steps as in initial comment
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The patch just updates the name seen in the ui after the user changes it.
• String changes made/needed: none
• Is Android affected?: Yes

Comment 16

[Pascal Chevrel:pascalc]

Comment on attachment 9352852 [details] [review]
[mozilla-mobile/firefox-android] Bug 1807127 - Update Sync Device name after refreshing fxa devices (backport #1576) (#3617)

Approved for 118.0b9 (last beta)  thanks.

Comment 17

[BMO Github Automation]

Authored by https://github.com/DreVla
https://github.com/mozilla-mobile/firefox-android/commit/cad72efab1543bd54b8cb96dfb10fd6967928c54
[releases_v118] Bug 1807127 - Update Sync Device name after refreshing fxa devices

Authored by https://github.com/pascalchevrel
https://github.com/mozilla-mobile/firefox-android/commit/5356a514072d141e45c7f249383557ed3f0cf1f8
[releases_v118] Merge pull request #3617 from mozilla-mobile/mergify/bp/releases_v118/pr-1576

Comment 18

[Lorand Janos]

Verified as fixed on the latest Beta build (118.0b9).
The changed device name is saved successfully.
Device used: Google Pixel 7 (Android 14)
Marking the ticket as verified for 118 as well.