1807157 - Intermittent SUMMARY: ThreadSanitizer: data race /builds/worker/workspace/obj-build/dist/include/nsCOMPtr.h:807:18 in swap or nsCOMPtr.h:867:45 in operator bool

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Treeherder Bug Filer]

Filed by: rvandermeulen [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=400519728&repo=try
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/UAKmL0CES6K9L6kwNkiNYw/runs/0/artifacts/public/logs/live_backing.log

---

Encountered intermittently when running mochitest-devtools in TSAN mode.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: tsan log

Doesn't look like the same race as bug 1806936, but feel free to dupe it over if it is.

Comment 2

[Intermittent Failures Robot]

3 failures in 2999 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• try: 3

Platform and build breakdown:

• linux1804-64-tsan-qr: 3
  • opt: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1807157&startday=2022-12-19&endday=2022-12-25&tree=all

Comment 3

[Natalia Csoregi [:nataliaCs]]

First occurrence so far on mozilla-central: push

Comment 4

[Intermittent Failures Robot]

3 failures in 1328 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 2
• autoland: 1

Platform and build breakdown:

• linux1804-64-tsan-qr: 3
  • opt: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1807157&startday=2022-12-26&endday=2023-01-01&tree=all

Comment 5

[Intermittent Failures Robot]

6 failures in 2607 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 5
• mozilla-central: 1

Platform and build breakdown:

• linux1804-64-tsan-qr: 6
  • opt: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1807157&startday=2023-01-02&endday=2023-01-08&tree=all

Comment 6

[Tim Huang[:timhuang]]

Attachment: Bug 1807157 - Add a mUpdateObserverLock in nsUrlClassifierDBService to protect mUpdateObserver. r?dimi!

The member variable mUpdateObserver of nsUrlClassifierDBService can be
accessed by both the main thread and the worker thread. This patch adds
a lock to protect it from race condition.

Comment 7

[Intermittent Failures Robot]

3 failures in 3530 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1
• autoland: 2

Platform and build breakdown:

• linux1804-64-tsan-qr: 3
  • opt: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1807157&startday=2023-01-09&endday=2023-01-15&tree=all

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b3c3c2c4825
Add a mUpdateObserverLock in nsUrlClassifierDBService to protect mUpdateObserver. r=dimi

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/4b3c3c2c4825

Comment 10

[Intermittent Failures Robot]

6 failures in 3717 pushes (0.002 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 5
• mozilla-beta: 1

Platform and build breakdown:

• linux1804-64-tsan-qr: 6
  • opt: 6

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1807157&startday=2023-01-16&endday=2023-01-22&tree=all

Comment 11

[Intermittent Failures Robot]

1 failures in 3914 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1

Platform and build breakdown:

• linux1804-64-tsan-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1807157&startday=2023-01-23&endday=2023-01-29&tree=all

Comment 12

[Intermittent Failures Robot]

1 failures in 3606 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-beta: 1

Platform and build breakdown:

• linux1804-64-tsan-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1807157&startday=2023-01-30&endday=2023-02-05&tree=all