1807198 - Extend preference to disable WritableFileStream in all contexts

Status: RESOLVED FIXED

(Core :: DOM: File, defect, P3)

Description

[Jari Jalkanen [:jari]]

In the review of https://phabricator.services.mozilla.com/D162319 related to https://bugzilla.mozilla.org/show_bug.cgi?id=1802279 , a doubt was raised:

AFAIK, nobody uses it even on workers and since WritableFileStream isn't plugged into quota management and we want to enable OPFS by default on Nightly soon, I think it would be safer to just disable WritableFileStream in all contexts for now. We don't expect to last this for long time, probably only one release cycle.

Currently, if someone wants to use OPFS, they have to set the dom.fs.enabled pref anyway and if they want to experiment with WritableFileStream, they can set the additional pref. We would at least know that there are some users and we could warn them about possible problems.

We should also add a comment for the additional pref (dom.fs.writable_file_stream.enabled) that WritableFileStream implementation is only experimental, that is does synchronous IO and that it doesn't update quota information (which is not such big problem when the app starts always with a fresh profile).

This bug addresses the comment above.

Comment 1

[Jari Jalkanen [:jari]]

Attachment: Bug 1807198 - Extend preference to disable WritableFileStream in all contexts. r=#dom-storage

Depends on D162319

Comment 2

[Phabricator Automation]

Comment on attachment 9309663 [details]
Bug 1807198 - Extend preference to disable WritableFileStream in all contexts. r=#dom-storage

Revision D165447 was moved to bug 1802279. Setting attachment 9309663 [details] to obsolete.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1798459

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

This bug has the keyword regression, so its type should be defect.

Comment 5

[Jari Jalkanen [:jari]]

This is fixed by 1802279 : the static preferences flag dom.fs.writable_file_stream.enabled is true for all OPFS test contexts, otherwise false.

Comment 6

[Jan Varga [:janv]]

Yeah, https://phabricator.services.mozilla.com/D165447 should have been attached to this bug, but it's not a big deal. I'm updating the bug summary at least.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jjalkanen, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox109 to wontfix.

For more information, please visit auto_nag documentation.