1807218 - Runing flake8 fix on testing/marionette/harness/marionette_harness/tests/unit/test_file_upload.py reports nothing found, but it actually fixes something

Status: NEW

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Marco Castelluccio [:marco]]

Running "mach -l flake8 --fix testing/marionette/harness/marionette_harness/tests/unit/test_file_upload.py" (the file contents are https://searchfox.org/mozilla-central/rev/b0844a16d60042c8e1e8f50465a89c1696d283fb/testing/marionette/harness/marionette_harness/tests/unit/test_file_upload.py#21) reports "✖ 0 problems (0 errors, 0 warnings, 0 fixed)", but the file is actually modified.
Line 21 turns from:

upload = lambda url: "data:text/html,{}".format(

to:

def upload(url): return "data:text/html,{}".format(

Comment 1

[Andrew Halberstadt [:ahal]]

This is because we use a separate tool (autopep8) to do the fixing. We should probably pull that out into a separate formatter, or just drop it completely.