1807235 - Perma TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_autoFill_backspaced.js | autofilled value is as expected - "exam" == "example.com/" when Gecko 110 merges to Beta on 2023-01-16

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Serban Stanca [:SerbanS]]

Central-as-beta-simulation

How to run these simulations

Failure log

[task 2022-12-23T12:39:43.704Z] 12:39:43     INFO - TEST-OK | browser/components/urlbar/tests/browser/browser_add_search_engine.js | took 5196ms
[task 2022-12-23T12:39:43.710Z] 12:39:43     INFO - GECKO(996) | [Child 3036: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 210b4640400 == 1 [pid = 3036] [id = 22]
[task 2022-12-23T12:39:43.711Z] 12:39:43     INFO - GECKO(996) | [Child 3036: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 3 (210af680bb0) [pid = 3036] [serial = 57] [outer = 0]
[task 2022-12-23T12:39:43.712Z] 12:39:43     INFO - GECKO(996) | [Child 3036: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 4 (210b4641000) [pid = 3036] [serial = 58] [outer = 210af680bb0]
[task 2022-12-23T12:39:43.728Z] 12:39:43     INFO - checking window state
[task 2022-12-23T12:39:43.750Z] 12:39:43     INFO - TEST-START | browser/components/urlbar/tests/browser/browser_autoFill_backspaced.js
[task 2022-12-23T12:39:43.780Z] 12:39:43     INFO - GECKO(996) | [Parent 7084, Main Thread] WARNING: '!mOwner', file /builds/worker/checkouts/gecko/dom/events/Event.cpp:746
[task 2022-12-23T12:39:43.797Z] 12:39:43     INFO - GECKO(996) | [Child 4776: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 3 (25a69190800) [pid = 4776] [serial = 60] [outer = 0] [url = about:blank]
[task 2022-12-23T12:39:43.798Z] 12:39:43     INFO - GECKO(996) | [Child 4776: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (25a6784a400) [pid = 4776] [serial = 61] [outer = 0] [url = about:privatebrowsing]
[task 2022-12-23T12:39:43.910Z] 12:39:43     INFO - TEST-INFO | started process screenshot
[task 2022-12-23T12:39:43.979Z] 12:39:43     INFO - TEST-INFO | screenshot: exit 0
[task 2022-12-23T12:39:43.988Z] 12:39:43     INFO - Buffered messages logged at 12:39:43
[task 2022-12-23T12:39:43.989Z] 12:39:43     INFO - Entering test bound 
[task 2022-12-23T12:39:43.990Z] 12:39:43     INFO - DELETE the autofilled part should search
[task 2022-12-23T12:39:43.991Z] 12:39:43     INFO - Awaiting for the urlbar panel to open
[task 2022-12-23T12:39:43.991Z] 12:39:43     INFO - Urlbar panel opened
[task 2022-12-23T12:39:43.991Z] 12:39:43     INFO - Buffered messages finished
[task 2022-12-23T12:39:43.992Z] 12:39:43     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_autoFill_backspaced.js | autofilled value is as expected - "exam" == "example.com/" - JS frame :: chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_autoFill_backspaced.js :: test_autocomplete :: line 19
[task 2022-12-23T12:39:43.992Z] 12:39:43     INFO - Stack trace:
[task 2022-12-23T12:39:43.992Z] 12:39:43     INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_autoFill_backspaced.js:test_autocomplete:19
[task 2022-12-23T12:39:43.993Z] 12:39:43     INFO - Synthesizing keys
[task 2022-12-23T12:39:43.993Z] 12:39:43     INFO - GECKO(996) | [Parent 7084, Main Thread] WARNING: nsFrameSelection::CreateRangeExtendedToNextGraphemeClusterBoundary() failed: 'result.isOk()', file /builds/worker/checkouts/gecko/editor/libeditor/AutoRangeArray.cpp:269
[task 2022-12-23T12:39:43.994Z] 12:39:43     INFO - GECKO(996) | [Parent 7084, Main Thread] WARNING: AutoRangeArray::ExtendAnchorFocusRangeFor() failed: file /builds/worker/checkouts/gecko/editor/libeditor/TextEditSubActionHandler.cpp:667
[task 2022-12-23T12:39:43.995Z] 12:39:43     INFO - GECKO(996) | [Parent 7084, Main Thread] WARNING: TextEditor::HandleDeleteSelectionInternal(eNoStrip) failed: 'result.isOk()', file /builds/worker/checkouts/gecko/editor/libeditor/TextEditSubActionHandler.cpp:610
[task 2022-12-23T12:39:43.996Z] 12:39:43     INFO - GECKO(996) | [Parent 7084, Main Thread] WARNING: TextEditor::HandleDeleteSelection() failed: file /builds/worker/checkouts/gecko/editor/libeditor/EditorBase.cpp:4232
[task 2022-12-23T12:39:43.996Z] 12:39:43     INFO - GECKO(996) | [Parent 7084, Main Thread] WARNING: EditorBase::DeleteSelectionAsSubAction() failed: 'NS_SUCCEEDED(rv)', file /builds/worker/checkouts/gecko/editor/libeditor/EditorBase.cpp:4195
[task 2022-12-23T12:39:43.997Z] 12:39:43     INFO - GECKO(996) | [Parent 7084, Main Thread] WARNING: EditorBase::DeleteSelectionAsAction() failed, but ignored: 'NS_SUCCEEDED(rvIgnored)', file /builds/worker/checkouts/gecko/editor/libeditor/EditorBase.cpp:4965
[task 2022-12-23T12:39:43.997Z] 12:39:43     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_autoFill_backspaced.js | backspaced value is as expected - "exam" == "exam" - 
[task 2022-12-23T12:39:43.998Z] 12:39:43     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_autoFill_backspaced.js | Should get at least 1 result - 3 > 0 - 
[task 2022-12-23T12:39:43.999Z] 12:39:43     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_autoFill_backspaced.js | Should have the correct result type - 2 == 2 - 
[task 2022-12-23T12:39:43.999Z] 12:39:43     INFO - DELETE the final slash should visit
[task 2022-12-23T12:39:44.000Z] 12:39:44     INFO - GECKO(996) | [Parent 7084, Main Thread] WARNING: '!mOwner', file /builds/worker/checkouts/gecko/dom/events/Event.cpp:746
[task 2022-12-23T12:39:44.000Z] 12:39:44     INFO - Awaiting for the urlbar panel to open
[task 2022-12-23T12:39:44.000Z] 12:39:44     INFO - Urlbar panel opened
[task 2022-12-23T12:39:44.058Z] 12:39:44     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-12-23T12:39:44.071Z] 12:39:44     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_autoFill_backspaced.js | autofilled value is as expected - "example.com" == "example.com/" - JS frame :: chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_autoFill_backspaced.js :: test_autocomplete :: line 19
[task 2022-12-23T12:39:44.071Z] 12:39:44     INFO - Stack trace:
[task 2022-12-23T12:39:44.071Z] 12:39:44     INFO - chrome://mochitests/content/browser/browser/components/urlbar/tests/browser/browser_autoFill_backspaced.js:test_autocomplete:19
[task 2022-12-23T12:39:44.071Z] 12:39:44     INFO - Synthesizing keys
[task 2022-12-23T12:39:44.076Z] 12:39:44     INFO - GECKO(996) | [Parent 7084, Main Thread] WARNING: nsFrameSelection::CreateRangeExtendedToNextGraphemeClusterBoundary() failed: 'result.isOk()', file /builds/worker/checkouts/gecko/editor/libeditor/AutoRangeArray.cpp:269
[task 2022-12-23T12:39:44.077Z] 12:39:44     INFO - GECKO(996) | [Parent 7084, Main Thread] WARNING: AutoRangeArray::ExtendAnchorFocusRangeFor() failed: file /builds/worker/checkouts/gecko/editor/libeditor/TextEditSubActionHandler.cpp:667
[task 2022-12-23T12:39:44.077Z] 12:39:44     INFO - GECKO(996) | [Parent 7084, Main Thread] WARNING: TextEditor::HandleDeleteSelectionInternal(eNoStrip) failed: 'result.isOk()', file /builds/worker/checkouts/gecko/editor/libeditor/TextEditSubActionHandler.cpp:610
[task 2022-12-23T12:39:44.078Z] 12:39:44     INFO - GECKO(996) | [Parent 7084, Main Thread] WARNING: TextEditor::HandleDeleteSelection() failed: file /builds/worker/checkouts/gecko/editor/libeditor/EditorBase.cpp:4232
[task 2022-12-23T12:39:44.079Z] 12:39:44     INFO - GECKO(996) | [Parent 7084, Main Thread] WARNING: EditorBase::DeleteSelectionAsSubAction() failed: 'NS_SUCCEEDED(rv)', file /builds/worker/checkouts/gecko/editor/libeditor/EditorBase.cpp:4195
[task 2022-12-23T12:39:44.079Z] 12:39:44     INFO - GECKO(996) | [Parent 7084, Main Thread] WARNING: EditorBase::DeleteSelectionAsAction() failed, but ignored: 'NS_SUCCEEDED(rvIgnored)', file /builds/worker/checkouts/gecko/editor/libeditor/EditorBase.cpp:4965
[task 2022-12-23T12:39:44.080Z] 12:39:44     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_autoFill_backspaced.js | backspaced value is as expected - "example.com" == "example.com" - 

Comment 1

[Marco Bonardo [:mak] (Away 10-21 August)]

Is this different from Bug 1805225?

Comment 2

[Marco Bonardo [:mak] (Away 10-21 August)]

Sorry wrong bug.

Comment 3

[Marco Bonardo [:mak] (Away 10-21 August)]

This is really surprising, investigating.

Comment 4

[Marco Bonardo [:mak] (Away 10-21 August)]

The reason for the failure is that the default bookmarks rise the autofill threshold over the one of "example.com" added by the test itself.
So it is sufficient to either remove the existing bookmarks and history to lower the threshold, or bookmark the page in the test so it ignores the threshold.
Though, I still want to verify why this is happening just now, maybe it's because we changed the default bookmarks recently, or a shift in timings.

Comment 5

[Marco Bonardo [:mak] (Away 10-21 August)]

Attachment: Bug 1807235 - Fix test to pass in beta with different default bookmarks. r=daisuke,adw

The test is passing in Nightly but failing in Beta because Beta has multiple
default bookmarks pointing to the same domain. The test always fails when run
alone, but used to pass when run with others because a previous test caused
bookmarked pages frecencies to be set to -1 (recalculate). With the new frecency
handling the frecencies remain valid until recalculated, and example.com is not
over the minimum threshold for being autofilled by the test.
By adding a temporary bookmark to it, we solve the threshold problem.

Comment 6

[Serban Stanca [:SerbanS]]

Patch is working in today's central as beta simulation.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec9efc04322c
Fix test to pass in beta with different default bookmarks. r=daisuke

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ec9efc04322c

Comment 9

[Sandor Molnar[:smolnar]]

Verified fixed in latest beta-sim