1807250 - Persistent search tip records as as tip_unknown

Status: VERIFIED FIXED

(Firefox :: Address Bar, enhancement)

Description

[Adrian Florinescu [:aflorinescu]]

Found in

• 110.0a1

Affected versions

• 110.0a1 (2022-12-22)

Tested platforms

• Windows 10

Preconditions

• browser.urlbar.searchEngagementTelemetry.enabled set true
• devtools.chrome.enabled set true
• browser.urlbar.searchTips.test.ignoreShowLimits set true (triggers all tips to always show && ingore counters )
• browser.urlbar.showSearchTerms.featureGate set true

Steps to reproduce

1. Open browser console and execute: Services.fog.testResetFOG();
2. Open a new tab and perform any search from the address bar.
3. If any tips are displayed, consume them (Okay, got it) and then execute: Services.fog.testResetFOG(); to reset the recorded pings.
4. Click In the address bar where the persistent search term is present.
5. Press Okay, got it in the persistent tip that is shown.
6. Execute in browser console Glean.urlbar.engagement.testGetValue()

Expected result
Something like tip_search_persistent should be recorded.

Actual result
Engagement type ping is recorded, last ping containing:

• results: tip_unknown
• selected_result: tip_unknown

Regression range

• New feature, N/A

Comment 1

[Daisuke Akatsuka (:daisuke)]

Thank you very much, Adrian!
Yeah, now, we have not supported persisted search terms yet and it isn't in our doc yet, but we should, I think.
I will do it.

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1807250: Support tip_persist type.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/44783d69a752
Support tip_persist type. r=mak

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/44783d69a752

Comment 5

[Adrian Florinescu [:aflorinescu]]

Verified during the Nightly 110 testrun on Windows 10 and Ubuntu 22.04 that tip_persist is recorded instead of unknown when the address bar is supporting persisted search terms.