Replace getAllLogins() with getAllLoginsAsync()
Categories
(Toolkit :: Password Manager, task, P1)
Tracking
()
Tracking | Status | |
---|---|---|
firefox117 | --- | fixed |
People
(Reporter: serg, Assigned: enndeakin)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
(Whiteboard: [fxcm-test-debt])
Attachments
(1 file, 1 obsolete file)
getAllLogins()
is deprecated and it's time we clean this up
Reporter | ||
Updated•1 year ago
|
Updated•1 year ago
|
Reporter | ||
Updated•1 year ago
|
Reporter | ||
Updated•1 year ago
|
Assignee | ||
Comment 1•11 months ago
|
||
Going to try this.
Assignee | ||
Comment 2•11 months ago
|
||
Pushed by neil@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5be10443a2ea replace all usage of getAllLogins with the asynchronous version, removing the syncronous version, r=credential-management-reviewers,sync-reviewers,sgalich,skhamis
Comment 4•10 months ago
|
||
Backed out for mochitest failures on test_autocomplete_password_generation.html.
Failure log: https://treeherder.mozilla.org/logviewer?job_id=419494714&repo=autoland
Backout link: https://hg.mozilla.org/integration/autoland/rev/d0a0051476569bf36bbf4b811e6a35edd17bbaa2
Assignee | ||
Comment 5•9 months ago
|
||
I don't see this error at all locally or on try, so I'm not sure what is up here.
Assignee | ||
Comment 6•9 months ago
|
||
This affects the test test_autocomplete_password_generation.html due to a timing issue. A password field is focused and closePopup ends up being called but the popup is already closed. By the time the parent receives the message, an attempt to open to popup has already occurred causing the popup to close again; the test fails as there aren't any items in the popup.
I'm not entirely convinced this fixes the test but I can rarely reproduce it only on Linux and cannot with this change.
Depends on D178406
Pushed by neil@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/149b536f4fed replace all usage of getAllLogins with the asynchronous version, removing the syncronous version, r=credential-management-reviewers,sync-reviewers,sgalich,skhamis https://hg.mozilla.org/integration/autoland/rev/548365f1d102 check if autocomplete popup is open before sending close popup message, r=mak
Comment 8•9 months ago
|
||
Backed out for autocomplete related failures.
- Push with failures - junits
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | org.mozilla.geckoview.test.AutocompleteTest#creditCardSelectDismiss | org.mozilla.geckoview.test.util.UiThreadUtils$TimeoutException: Timed out after 30000ms
- Push with failures - mochitests plain
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | toolkit/components/passwordmgr/test/mochitest/test_autocomplete_password_generation.html | Check first item is the auto-saved login
Assignee | ||
Updated•9 months ago
|
Pushed by neil@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ae30a1ac484e replace all usage of getAllLogins with the asynchronous version, removing the syncronous version, r=credential-management-reviewers,sync-reviewers,sgalich,skhamis
Comment 10•9 months ago
|
||
bugherder |
Description
•