Closed Bug 1807618 Opened 1 year ago Closed 9 months ago

Replace getAllLogins() with getAllLoginsAsync()

Categories

(Toolkit :: Password Manager, task, P1)

task

Tracking

()

RESOLVED FIXED
117 Branch
Tracking Status
firefox117 --- fixed

People

(Reporter: serg, Assigned: enndeakin)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [fxcm-test-debt])

Attachments

(1 file, 1 obsolete file)

getAllLogins() is deprecated and it's time we clean this up

See Also: → 1721900
Depends on: 1807783
Whiteboard: [fxcm-tests]
Severity: -- → N/A
Priority: -- → P1
Whiteboard: [fxcm-tests] → [fxcm-test-debt]
Depends on: 1811142

Going to try this.

Assignee: nobody → enndeakin
Status: NEW → ASSIGNED
Pushed by neil@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5be10443a2ea
replace all usage of getAllLogins with the asynchronous version, removing the syncronous version, r=credential-management-reviewers,sync-reviewers,sgalich,skhamis

I don't see this error at all locally or on try, so I'm not sure what is up here.

Flags: needinfo?(enndeakin)

This affects the test test_autocomplete_password_generation.html due to a timing issue. A password field is focused and closePopup ends up being called but the popup is already closed. By the time the parent receives the message, an attempt to open to popup has already occurred causing the popup to close again; the test fails as there aren't any items in the popup.

I'm not entirely convinced this fixes the test but I can rarely reproduce it only on Linux and cannot with this change.

Depends on D178406

Pushed by neil@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/149b536f4fed
replace all usage of getAllLogins with the asynchronous version, removing the syncronous version, r=credential-management-reviewers,sync-reviewers,sgalich,skhamis
https://hg.mozilla.org/integration/autoland/rev/548365f1d102
check if autocomplete popup is open before sending close popup message, r=mak

Backed out for autocomplete related failures.


  • Push with failures - junits
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | org.mozilla.geckoview.test.AutocompleteTest#creditCardSelectDismiss | org.mozilla.geckoview.test.util.UiThreadUtils$TimeoutException: Timed out after 30000ms

Flags: needinfo?(enndeakin)
Attachment #9341651 - Attachment is obsolete: true
Flags: needinfo?(enndeakin)
Pushed by neil@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ae30a1ac484e
replace all usage of getAllLogins with the asynchronous version, removing the syncronous version, r=credential-management-reviewers,sync-reviewers,sgalich,skhamis
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 117 Branch
Regressions: 1844233
Depends on: 1850535
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: