1807646 - "Confirm before quitting with Ctrl+Q" is not aligned with checkbox

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Gregory Pappas [:gregp]]

Attachment: not_aligned.png

Steps to reproduce:

1. Set browser.warnOnQuit to true in about:config
2. Try quitting Firefox with Ctrl+Q shortcut

Actual results:
"Confirm before quitting with Ctrl+Q" is not aligned with checkbox

Expected results:
"Confirm before quitting with Ctrl+Q" is aligned with checkbox

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1779695

:emilio, since you are the author of the regressor, bug 1779695, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1807646 - Fix up dialog checkbox alignment. r=Gijs

The 100% was resolving to 0 with XUL. That said I don't think we have a
multi-line dialog here, and if we had I don't think it'd behave
correctly either with or without the patch (or before the regressing bug
for that matter).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b0ce2a20f13
Fix up dialog checkbox alignment. r=Gijs

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1b0ce2a20f13

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox109 to wontfix.

For more information, please visit auto_nag documentation.

Comment 6

[Emilio Cobos Álvarez [:emilio]]

It's an extremely minor visual issue, I think it can ride the trains, but lmk if you disagree.

Comment 7

[Alexandru Trif, Desktop Test Engineering [:atrif]]

This was verified as part of bug 1807975#15. The check box is now correctly aligned with the Confirm before quitting with Ctrl+Q message on Windows 10x64, macOS 10.15 and Ubuntu 20.04 while using Firefox 110.0b2.