Closed Bug 1807650 Opened 1 year ago Closed 1 year ago

Remove old "network monitor" server APIs

Categories

(DevTools :: Netmonitor, task)

task

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1721592

People

(Reporter: ochameau, Assigned: ochameau)

References

(Blocks 1 open bug)

Details

Attachments

(2 obsolete files)

With bug 1625937, we removed the last usage of NetworkActivity webconsole listener.
We can now remove the old NetworkMonitor and NetworkEvent actors and all its dependencies.

With the removal of the old non-fission browser toolbox,
we removed the last usage of this old codebase.
We used to be able to listen to network events via WebConsole's actor's startListeners method.
Nowadays we should rather use the Watcher actor's watchResources method and listen to
NETWORK_EVENT resource.
(or migrate to WebDriver Bidi which will soon allow to listen to network requests see bug 1790369)

This patch also removed:

  • all now unused block* requests from webconsole actor,
  • spawnActorInParent which was only used by this code,
  • code in the frontend assuming that we still had to go through the webconsole/emulation actors to block and throttle requests,
  • remove emulation actor method to handle throttling.
Assignee: nobody → poirot.alex
Status: NEW → ASSIGNED

This required a small workaround in ResourceCommand in order to avoid
trying to spawn network event legacy listeners for workers.
The old legacy listener were bailing out for workers...

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Duplicate of bug: 1721592
Resolution: --- → DUPLICATE

Comment on attachment 9309980 [details]
Bug 1807650 - [devtools] Remove old server codebase to listen to network events.

Revision D165603 was moved to bug 1721592. Setting attachment 9309980 [details] to obsolete.

Attachment #9309980 - Attachment is obsolete: true

Comment on attachment 9309981 [details]
Bug 1807650 - [devtools] Remove network legacy listeners.

Revision D165604 was moved to bug 1721592. Setting attachment 9309981 [details] to obsolete.

Attachment #9309981 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: