1807664 - Perma Late-beta TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_glean_telemetry_abandonment_search_mode.js | Found one-off button for search mode - "undefined" == true - JS frame when Switch from Early Beta to Late Beta 2023-01-27

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Iulian Moraru]

[Tracking Requested - why for this release]:

• Central-as-beta simulation.
• How to run these simulations.

Failure log:

[task 2022-12-27T12:31:43.253Z] 12:31:43     INFO - TEST-PASS | browser/components/urlbar/tests/browser/browser_glean_telemetry_abandonment_search_mode.js | One-offs are visible - true == true - 
[task 2022-12-27T12:31:43.254Z] 12:31:43     INFO - Buffered messages finished
[task 2022-12-27T12:31:43.255Z] 12:31:43     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_glean_telemetry_abandonment_search_mode.js | Found one-off button for search mode - "undefined" == true - JS frame :: resource://testing-common/UrlbarTestUtils.sys.mjs :: enterSearchMode :: line 725
[task 2022-12-27T12:31:43.256Z] 12:31:43     INFO - Stack trace:
[task 2022-12-27T12:31:43.257Z] 12:31:43     INFO - resource://testing-common/UrlbarTestUtils.sys.mjs:enterSearchMode:725
[task 2022-12-27T12:31:43.257Z] 12:31:43     INFO - Not taking screenshot here: see the one that was previously logged
[task 2022-12-27T12:31:43.259Z] 12:31:43     INFO - TEST-UNEXPECTED-FAIL | browser/components/urlbar/tests/browser/browser_glean_telemetry_abandonment_search_mode.js | Uncaught exception in test - at chrome://mochikit/content/tests/SimpleTest/EventUtils.js:729 - TypeError: aTarget is undefined
[task 2022-12-27T12:31:43.260Z] 12:31:43     INFO - Stack trace:
[task 2022-12-27T12:31:43.260Z] 12:31:43     INFO - synthesizeMouseAtCenter@chrome://mochikit/content/tests/SimpleTest/EventUtils.js:729:14
[task 2022-12-27T12:31:43.260Z] 12:31:43     INFO - enterSearchMode@resource://testing-common/UrlbarTestUtils.sys.mjs:726:21
[task 2022-12-27T12:31:43.261Z] 12:31:43     INFO - Leaving test bound search_mode_actions
[task 2022-12-27T12:31:43.263Z] 12:31:43     INFO - GECKO(5585) | [Child 5655: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 7ff7daede000 == 5 [pid = 5655] [id = 7] [url = moz-extension://d7034cca-a2a1-4465-818c-b46c73bca08e/page.html]
[task 2022-12-27T12:31:43.264Z] 12:31:43     INFO - GECKO(5585) | [Child 5655: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 12 (7ff7d9c8a280) [pid = 5655] [serial = 22] [outer = 0] [url = moz-extension://d7034cca-a2a1-4465-818c-b46c73bca08e/page.html]
[task 2022-12-27T12:31:43.458Z] 12:31:43     INFO - GECKO(5585) | MEMORY STAT | vsize 12165MB | residentFast 628MB | heapAllocated 326MB
[task 2022-12-27T12:31:43.460Z] 12:31:43     INFO - TEST-OK | browser/components/urlbar/tests/browser/browser_glean_telemetry_abandonment_search_mode.js | took 7594ms
[task 2022-12-27T12:31:43.473Z] 12:31:43     INFO - GECKO(5585) | [Child 5725: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7fbc86c81400 == 2 [pid = 5725] [id = 94]
[task 2022-12-27T12:31:43.474Z] 12:31:43     INFO - GECKO(5585) | [Child 5725: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 9 (7fbc8c7ab470) [pid = 5725] [serial = 246] [outer = 0]
[task 2022-12-27T12:31:43.477Z] 12:31:43     INFO - GECKO(5585) | [Child 5725: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 10 (7fbc86c81c00) [pid = 5725] [serial = 247] [outer = 7fbc8c7ab470]
[task 2022-12-27T12:31:43.513Z] 12:31:43     INFO - checking window state
[task 2022-12-27T12:31:43.570Z] 12:31:43     INFO - TEST-START | browser/components/urlbar/tests/browser/browser_glean_telemetry_engagement_groups.js

Comment 1

[Iulian Moraru]

I think this issue was happening since this late-beta simulation. This failure line was hidden by the issue from Bug 1807235, as we can see here. Btw, Bug 1807235 has a working patch and it was used in today's beta sim.

Comment 2

[Iulian Moraru]

Hi Drew! Can you please take a look at this? Maybe you can spot what caused this.
Thank you!

Comment 3

[Iulian Moraru]

Hi Daisuke! Could this, by any chance, be regressed by your recent changes in Bug 1805717? Can you please take a look?
Thank you!

Comment 4

[Daisuke Akatsuka (:daisuke)]

Hi Iulian!
Thank you very much for letting me know.
I will take a look at this.

Comment 5

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1807664: Enable quickactions oneoff button explicitly.

Comment 6

[Sandor Molnar[:smolnar]]

Patch is working in today's beta-sim

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7098ba63b75d
Enable quickactions oneoff button explicitly. r=mak

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/7098ba63b75d