1807879 - SheetLoadData destructor missing ifdef MOZ_DIAGNOSTIC_ASSERT_ENABLED

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Alex Vincent [:WeirdAl]]

I stumbled across this entirely by accident, with an experimental project.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

It was changed to a release assert in https://hg.mozilla.org/mozilla-central/rev/17e0bbb609a9 without changing the members. Was that intentional?

Comment 2

[Kershaw Chang [:kershaw]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #1)

It was changed to a release assert in https://hg.mozilla.org/mozilla-central/rev/17e0bbb609a9 without changing the members. Was that intentional?

No, that's my bad. I was not aware of that two members are inside MOZ_DIAGNOSTIC_ASSERT_ENABLED.
I'll submit a patch soon.

Comment 3

[Kershaw Chang [:kershaw]]

Attachment: Bug 1807879 - Remove MOZ_DIAGNOSTIC_ASSERT_ENABLED for mSheetCompleteCalled and mIntentionallyDropped, r=emilio

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/94b122e08b2b
Remove MOZ_DIAGNOSTIC_ASSERT_ENABLED for mSheetCompleteCalled and mIntentionallyDropped, r=emilio DONTBUILD

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/94b122e08b2b

Comment 7

[Alex Vincent [:WeirdAl]]

I've confirmed this works with my experimental project. Thanks for the quick turnaround!

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9310080 [details]
Bug 1807879 - Remove MOZ_DIAGNOSTIC_ASSERT_ENABLED for mSheetCompleteCalled and mIntentionallyDropped, r=emilio

Approved for 109.0b8 and 102.7esr.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/06caacedf1de

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/21e07abfaa8e