1807959 - Remove libwebrtc build mitigations landed in 699496c38ca1

Status: RESOLVED FIXED

(Core :: WebRTC, task, P2)

Description

[Michael Froman [:mjf]]

In 699496c38ca1 Bug 1654112 - fix try builds for macos. we landed changes to fix build errors that are no longer necessary for our builds. Removing this change will make the fast-forward process smoother by removing the need to add casting fixes to various upstream commits.

Comment 1

[Michael Froman [:mjf]]

Our magic try string looks good here. The one build related failure also fails on central with no changes here.

Comment 2

[Michael Froman [:mjf]]

Attachment: Bug 1807959 - pt1 - remove build mitigations from 699496c38ca1 (Bug 1654112 - fix try builds for macos.) r?ng!

Comment 3

[Michael Froman [:mjf]]

Attachment: Bug 1807959 - pt2 - remove all casting fixes from libwebrtc. r?ng!

Reverts the following commits:
291351e28be1 - Bug 1766646 - (fix-62b6c92298) fix casting like in Bug 1654112 - fix try builds for macos
11592e575991 - Bug 1766646 - (fix-e902f28d2a) fix casting issue
53c81a729001 - Bug 1766646 - (fix-2ddc39e2b9) fix casting issue
de4d4bd3be12 - Bug 1766646 - (fix-9a99905301f) fix a casting issue
77d0769c98e8 - Bug 1766646 - (fix-d6cdf80072) fix casting issue
ffdb4b370427 - Bug 1790097 - (fix-88af20356f) fix casting issue
0e2a8032b2dc - Bug 1800920 - (fix-7aaeb5a270) fix casting issue

Depends on D165691

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/999a1d45946a
pt1 - remove build mitigations from 699496c38ca1 (Bug 1654112 - fix try builds for macos.) r=ng
https://hg.mozilla.org/integration/autoland/rev/58427dce4597
pt2 - remove all casting fixes from libwebrtc. r=ng

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/999a1d45946a
https://hg.mozilla.org/mozilla-central/rev/58427dce4597