Download notification icon has a black stroke
Categories
(Firefox :: Theme, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr102 | --- | unaffected |
| firefox108 | --- | unaffected |
| firefox109 | --- | unaffected |
| firefox110 | + | fixed |
People
(Reporter: kazz, Assigned: longsonr)
References
(Regression)
Details
(Keywords: regression)
Attachments
(1 file)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:109.0) Gecko/20100101 Firefox/110.0
Steps to reproduce:
Regressed by 1807479
Download notification icon which is shown on hamburger menu has a black stroke now.
notification-fill-12.svg - mozsearch has fill="context-stroke" but indicator.css - mozsearch only has fill, so fallback color for fill, that is black, is applied.
Actual results:
notification icon with black stroke
Expected results:
notification icon without a stroke
|
||
Updated•1 year ago
|
|
|
||
Comment 1•1 year ago
|
||
:longsonr, since you are the author of the regressor, bug 1807479, could you take a look? Also, could you set the severity field?
For more information, please visit auto_nag documentation.
|
Reporter | |
Comment 2•1 year ago
|
||
A suggested fix is to replace fill="context-stroke" with fill="context-stroke none" in the SVG file.
However, not only this SVG file, but also other SVG files that specify fill="context-stroke" as well should be replaced.
Ref: fill="context-stroke" - mozsearch
Files that specify stroke="context-fill" should also be replaced with stroke="context-fill black".
Ref: stroke="context-fill" - mozsearch
|
Assignee | |
Comment 3•1 year ago
|
||
The stroke doesn't seem to be used so in that case the element should just be deleted.
|
|
Assignee | |
Comment 4•1 year ago
|
||
|
||
Updated•1 year ago
|
|
|
||
Comment 5•1 year ago
|
||
Set release status flags based on info from the regressing bug 1807479
|
|
Assignee | |
Comment 6•1 year ago
|
||
I'm fairly sure that stroke="context-fill" won't be a problem because of bug 1351243.
The only change in behaviour would be fill="context-stroke" where no context-stroke has been provided. Either removing the element, setting a fallback of none or actually providing a context-stroke (of none) could all work.
|
||
Updated•1 year ago
|
Pushed by longsonr@gmail.com: https://hg.mozilla.org/integration/autoland/rev/1634f825626c remove icon element that should never be displayed r=dao,amy
|
||
Comment 9•1 year ago
|
||
| bugherder | ||
Description
•