Open Bug 1808097 Opened 2 years ago Updated 2 years ago

locked browser.toolbars.bookmarks.visibility does not stop user from changing the bookmark visibility

Categories

(Firefox :: Toolbars and Customization, defect, P3)

Firefox 108
Desktop
All
defect

Tracking

()

Tracking Status
firefox108 --- affected
firefox109 --- affected
firefox110 --- affected

People

(Reporter: andmagdo, Unassigned)

Details

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:108.0) Gecko/20100101 Firefox/108.0

Steps to reproduce:

  1. Locked the preference browser.toolbars.bookmarks.visibility to the value newtab
  2. Pressed ctrl+shift+b

Actual results:

Firefox responded as if the preference was not locked. Not changing the preference, but still changing when the bookmarks bar is visible. When right-clicked, the bookmarks toolbar dropdown has 'only show on new tab' selected, even though it is set to always.

Clicking 'always show on new tab' does change the visibility back to newtab, and the other menu options do nothing.

Expected results:

Nothing; ctrl+shift+b should have been unable to change the visibility

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Widget: Gtk
Product: Firefox → Core
Component: Widget: Gtk → Toolbars and Customization
Product: Core → Firefox

We should check if the pref is locked here before continuing to set the pref and change the toolbar visibility,
https://searchfox.org/mozilla-central/rev/4ebfb48f7e82251145afa4a822f970931dd06c68/browser/base/content/browser.js#6692-6704

Severity: -- → S4
Priority: -- → P3

Manage to reproduce this on Windows 10 x64, Ubuntu 20.04 x64.

Status: UNCONFIRMED → NEW
Has STR: --- → yes
Ever confirmed: true
OS: Unspecified → All
Hardware: Unspecified → Desktop
You need to log in before you can comment on or make changes to this bug.