Closed Bug 1808126 Opened 2 years ago Closed 2 years ago

windows builds failing with updater disabled with unable to find commonupdatedir.h

Categories

(Firefox :: Launcher Process, defect)

defect

Tracking

()

RESOLVED FIXED
110 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox108 --- unaffected
firefox109 --- unaffected
firefox110 --- fixed

People

(Reporter: mac198442, Assigned: gstoll)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/110.0

Steps to reproduce:

Tried to build with --disable updater and --enable-tests

Actual results:

The build failed

Expected results:

the build should have worked

This appears to be regression from Bug 1744362.

Summary: updater → windows builds failing with updater disabled with unable to find commonupdatedir.h

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: General → Widget: Gtk
Component: Widget: Gtk → Launcher Process
Keywords: regression
Product: Core → Firefox
Regressed by: 1744362

:gstoll, since you are the author of the regressor, bug 1744362, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Flags: needinfo?(gstoll)

Yes, this is caused by bug 1744362 - the blocklist uses the install hash, which doesn't get compiled in with --disable-updater. I'll move that code out so all can access it.

Assignee: nobody → gstoll
Severity: -- → S3
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(gstoll)

Set release status flags based on info from the regressing bug 1744362

LauncherRegistryInfo was calling into GetInstallHash(), which was defined in the updater component, so the build was failing when building with --disable-launcher.

I tried extracting GetInstallHash() to somewhere common, but it turns out both the updater component (because it's not built into xul.dll) and LauncherRegistryInfo (because it runs from the launcher process) can only call certain things, and it's hard to find an overlap. Since the code is relatively straightforward, and there's no harm if it diverges I just copied it over and simplified it a bit.

(handyman is out for a while; feel free to pass this on to someone else if you'd like, as git history didn't turn up many people...)

Attachment #9310340 - Attachment description: Bug 1808126 - fix --disable-launcher build r=rkraesig → Bug 1808126 - fix --disable-launcher build r=yjuglaret
Attachment #9310340 - Attachment description: Bug 1808126 - fix --disable-launcher build r=yjuglaret → Bug 1808126 - fix --disable-updater build r=yjuglaret
Pushed by gstoll@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a80968ed4c85 fix --disable-updater build r=yjuglaret
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: