Closed
Bug 1808216
Opened 1 year ago
Closed 1 year ago
Improve StringBuffer API a bit
Categories
(Core :: JavaScript Engine, task, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
110 Branch
| Tracking | Status | |
|---|---|---|
| firefox110 | --- | fixed |
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(3 files)
We can improve StringBuffer a bit by taking either a JSContext* or a FrontendContext* as argument. This also lets us remove the JSContext* argument from FoldConstants.
|
Assignee | |
Comment 1•1 year ago
|
||
In StringBuffer::inflateChars we now copy the alloc policy from the Latin1 buffer.
This lets us remove the fc_ and arenaId_ fields from StringBuffer.
|
|
Assignee | |
Comment 2•1 year ago
|
||
Depends on D165827
|
|
Assignee | |
Comment 3•1 year ago
|
||
Depends on D165828
|
||
Updated•1 year ago
|
Severity: -- → N/A
Priority: -- → P1
Pushed by jdemooij@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fc7c37faf9b7 part 1 - Change StringBuffer constructor to take either JSContext* or FrontendContext* but not both. r=arai https://hg.mozilla.org/integration/autoland/rev/0e45a51c5b25 part 2 - Simplify JSStringBuilder API. r=arai https://hg.mozilla.org/integration/autoland/rev/97d3a9e5a867 part 3 - Remove JSContext* argument from FoldConstants. r=arai
|
||
Comment 5•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fc7c37faf9b7
https://hg.mozilla.org/mozilla-central/rev/0e45a51c5b25
https://hg.mozilla.org/mozilla-central/rev/97d3a9e5a867
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox110:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•