Closed Bug 1808293 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 37732 - [Sub Apps] Limit add() calls to at most 7 apps

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox111 fixed)

Status:
RESOLVED FIXED
Milestone:
111 Branch
Tracking Flags:
Tracking Status
firefox111 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Depends on 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 37732 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/37732
Details from upstream follow.

Philipp Weiß <phweiss@chromium.org> wrote:

[Sub Apps] Limit add() calls to at most 7 apps

To avoid overwhelming the user with an overloaded permissions prompt,
only allow 7 apps to be added at once.

Bug: 1402192
Test: third_party/blink/tools/run_web_tests.py external/wpt/subapps
Change-Id: I7ebb34c3700fdbf1b699debe78228d3bc4b889cc
Reviewed-on: https://chromium-review.googlesource.com/4127312
WPT-Export-Revision: 5933347797ca2e8dfe03ec69b4a0ee3177dc8ba6

PR 37732 applied with additional changes from upstream: 0467ad158d2390a4172bd1939a9d7b7f0f72e88d

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 8 subtests

Status Summary

Firefox

OK : 1
FAIL: 8

Chrome

OK : 1
FAIL: 8

Safari

OK : 1
FAIL: 8

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /subapps/add-error.tentative.https.html [wpt.fyi]
    • The object is no longer associated to a document.: FAIL (Chrome: FAIL, Safari: FAIL)
    • API is only supported in top-level browsing contexts.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Wrong origin URL argument.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Service failed to add single sub-app.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Missing user activation.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Too many subapps at once.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Service failed to add two sub-apps.: FAIL (Chrome: FAIL, Safari: FAIL)
    • Service added one sub-app failed to add another sub-app.: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b68df8d534de
[wpt PR 37732] - [Sub Apps] Limit add() calls to at most 7 apps, a=testonly
https://hg.mozilla.org/integration/autoland/rev/813a3116190d
[wpt PR 37732] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/b68df8d534de
https://hg.mozilla.org/mozilla-central/rev/813a3116190d

Status: NEW → RESOLVED
Closed: 1 year ago
status-firefox111: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in before you can comment on or make changes to this bug.