1808406 - stop using functools cache decorators on methods

Status: RESOLVED FIXED

(Socorro :: General, task, P2)

Description

[Will Kahn-Greene [:willkg] ET needinfo? me]

I found out that the functools cache decoratorated methods will include self as part of the cache key. Because of that, they cause those instances to stick around forever.

For example, this is bad:

from functools import cache

class Foo:
    @cache
    def calculate_things(self, a, b):
        return a * b

This will cache all Foo instances where calculate_things was called thus keeping those Foo instances around forever.

We should stop using functools cache decorators on methods.

Comment 1

[Will Kahn-Greene [:willkg] ET needinfo? me]

Attachment: pr 6296: bug 1808406: fix uses of functools.cache decorating methods

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

willkg merged PR #6296: "bug 1808406: fix uses of functools.cache decorating methods" in 5fce1b7.

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

This was pushed to prod just now in bug #1809927. Marking as FIXED.