1808429 - Make it easier to configure poisoning in jemalloc at runtime

Status: RESOLVED FIXED

(Core :: Memory Allocator, task, P1)

Description

[Paul Bone [:pbone]]

I have some patches that make it possible to turn poisoning in jemalloc off and on at runtime.

Comment 1

[Paul Bone [:pbone]]

Attachment: Bug 1808429 - Fix non-existant parameters in code comment r=glandium

This comment refers to parameters that don't exist. I assume it's
obsolete.

Comment 2

[Paul Bone [:pbone]]

Attachment: Bug 1808429 - Add the ability to enable and disable poisoning r=glandium

Poisoning was hardcoded, but to compare different allocators I wanted to
disable it. This patch lets us control poisoning with the MALLOC_OPTIONS
environment variable.

Depends on D165918

Comment 3

[Paul Bone [:pbone]]

Attachment: Bug 1808429 - Disconnect runtime configuration from MOZ_DEBUG r=glandium

Some of the runtime options are compiled-in constants when MOZ_DEBUG is not
defined. But it can be useful to enable these configuration options without
enabling the rest of MOZ_DEBUG (eg assertions). This patch adds a new
preprocessor macro to enable runtime configuration.

Depends on D165919

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db41ee75c736
Fix non-existant parameters in code comment r=glandium
https://hg.mozilla.org/integration/autoland/rev/c2eabcd996d7
Add the ability to enable and disable poisoning r=glandium
https://hg.mozilla.org/integration/autoland/rev/704ccaff06dd
Disconnect runtime configuration from MOZ_DEBUG r=glandium

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/db41ee75c736
https://hg.mozilla.org/mozilla-central/rev/c2eabcd996d7
https://hg.mozilla.org/mozilla-central/rev/704ccaff06dd