180861 - Form Submission should not know about PresContext

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[John Keiser (jkeiser)]

PresContext is 100% about content.  If there is something in PresContext that it
needs, either that resource is in the wrong place or there is a substitute in
content world that we can work with.

Three things I see in nsFormSubmission that use it:
- GetBidi() (Simon, can you shed light here?  Is there a method in content
somewhere we can use?)
- GetLinkClickHandler is in PresContext, but it's really nsWebShell, so we can
get the DocShell and QI to nsILinkHandler.  Even *better* might be to put the
method on DocShell and call it something else, since we're not really clicking a
link ;)
- GetEncoding() doesn't appear to need it anymore, even though we pass it in. 
Yay :)

The nsHTMLFormElement methods just need it to call into nsFormSubmission.

Comment 1

[John Keiser (jkeiser)]

Looks like there is a real bug related to this: if you try to submit a form
within a display: none iframe, it will fail because there is no PresContext.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Fixed by checkin for bug 100533.