Closed
Bug 1808691
Opened 1 year ago
Closed 1 year ago
ContentParent::MaybeBeginShutDown should avoid repeated SignalImpendingShutdownToContentJS
Categories
(Core :: DOM: Content Processes, task)
Core
DOM: Content Processes
Tracking
()
RESOLVED
FIXED
110 Branch
| Tracking | Status | |
|---|---|---|
| firefox110 | --- | fixed |
People
(Reporter: jstutte, Assigned: jstutte)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
From bug 1755376 comment 22 we see that NotifiedImpendingShutdown can happen more than once. The most likely source for this are repeated calls to MaybeBeginShutDown which should thus check for re-entrance.
|
Assignee | |
Updated•1 year ago
|
Blocks: IPCError_ShutDownKill
|
|
Assignee | |
Comment 1•1 year ago
|
||
MaybeBeginShutDown can be called more than once and with different consequences depending on parameters. In order to avoid sending shutdown messages to the child process more than once, we handle re-entrance of the called functions separately rather than relying on IsDead() here.
|
||
Updated•1 year ago
|
Assignee: nobody → jstutte
Status: NEW → ASSIGNED
|
|
||
Updated•1 year ago
|
Attachment #9310820 -
Attachment description: Bug 1808691 - Handle re-entrance in SignalImpendingShutdownToContentJS and MaybeAsyncSendShutDownMessage. r?smaug → Bug 1808691 - Handle re-entrance in SignalImpendingShutdownToContentJS. r?smaug
Pushed by jstutte@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9f2b606adb82 Handle re-entrance in SignalImpendingShutdownToContentJS. r=smaug
|
||
Comment 3•1 year ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox110:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•