1808741 - Disable setting the style attribute with lit styleMap

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task)

Description

[Mark Striemer [:mstriemer]]

By default lit sets the style="" attribute on first render to support server-side rendering. This isn't necessary for us since we can set properties using HTMLElement.style properties instead.

Setting the style="" attribute, rather than using the HTMLElement.style properties can cause problems on pages with a restrictive CSP, such as about:logins.

Comment 1

[Mark Striemer [:mstriemer]]

Attachment: Bug 1808741 - Patch lit's styleMap to not set the style attribute on first render r?sgalich,hjones

lit calls element.setAttribute("style", "<our styles>") on first render of an
element so that it will have the style property set in the markup if it is being
server-side rendered. We don't need that, and it causes CSP errors in
about:logins so this patches out the functionality.

https://github.com/lit/rfcs/issues/13

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d3793ddd16e
Patch lit's styleMap to not set the style attribute on first render r=mtigley

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/5d3793ddd16e