Closed Bug 1808747 Opened 3 years ago Closed 3 years ago

Add a way to associate a python support file to a test

Categories

(Testing :: Raptor, enhancement, P2)

enhancement

Tracking

(firefox114 fixed)

RESOLVED FIXED
114 Branch
Tracking Status
firefox114 --- fixed

People

(Reporter: sparky, Assigned: sparky)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxp])

Attachments

(1 file)

This bug is for adding a way to associate a python file to a test.

With a python file, we'll be able to greatly expand how much a test can customize it's setup, and parse it's results. This will make it simpler to handle all the various options we have for custom tests as well, see the grandprix test for instance: https://searchfox.org/mozilla-central/source/testing/raptor/raptor/tests/custom/browsertime-grandprix.ini#25-28

One issue we have is that Raptor results parsing is intermingled between results.py and output.py. This results in a lot of issues when it comes to parsing results and it forces us on the PerfTools team to constantly modify these files to add tests. This is because the files are very rigid in that it's very error-prone to customize your perfherder-data. With python files, we'll be able to skip certain areas of those files with custom user-defined behaviour making it easier for developers to add tests themselves.

Summary: Add a way to associate a python file to a test → Add a way to associate a python file to a test for results and output
Blocks: 1824183
Summary: Add a way to associate a python file to a test for results and output → Add a way to associate a python support file to a test
Whiteboard: [fxp]
See Also: → 1825074

This patch adds python support classes for tests. With them, we'll be able to customize the results, and output parsing better, and with less impact on other existing tests. The first method available allows a test author to modify the command before the test runs. A sample test is also added to show how it all works. No CI tests will be added for it.

Assignee: nobody → gmierz2
Status: NEW → ASSIGNED

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:sparky, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Flags: needinfo?(gmierz2)
Flags: needinfo?(afinder)
Pushed by gmierz2@outlook.com: https://hg.mozilla.org/integration/autoland/rev/9ee83fa2a0ed Add python test support class scripts to raptor. r=perftest-reviewers,afinder
Flags: needinfo?(gmierz2)
Flags: needinfo?(afinder)
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 114 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: