Closed Bug 1808794 Opened 1 year ago Closed 1 year ago

Do not use whether users have modified autofilled fields to determine if we should show doorhanger

Categories

(Toolkit :: Form Autofill, task, P2)

Product:
Toolkit
Component:
Form Autofill
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
111 Branch
Tracking Flags:
Tracking Status
firefox111 --- fixed

People

(Reporter: dimi, Assigned: dimi)

References

Details

(Whiteboard: [fxcm-bugs-2023])

Attachments

(1 file)

Bug 1808794 - Compare submitted data with data in storage to determine whether to show credit card doorhanger r=sgalich
48 bytes, text/x-phabricator-request
Details | Review

See here.
This logic is not always correct, for example:

  1. A user has two credit cards saved
  • 5555555555554444, John Doe, 12/2023
  • 4111111111111111, John Doe, 12/2023
  1. The user autofills the form with entry one (5555555555554444) and then manually change the credit card number to 4111111111111111. With the current logic, we will still show an credit card update doorhanger. The expected result should be not showing doorhanger at all since the submitted credit card i the same as one of the saved credit cards.
Summary: Do not use whether users have manually updated autofilled fields to determine if we should show doorhanger → Do not use whether users have modified autofilled fields to determine if we should show doorhanger
Severity: -- → N/A
Priority: -- → P2
Attachment #9311323 - Attachment description: Bug 1808794 - Do not use whether users have manually updated autofilled fields to determine if we should show doorhanger r=sgalich → Bug 1808794 - Compare submitted data with data in storage to determine whether to show credit card doorhanger r=sgalich
Pushed by dlee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/694cac8f2d3d
Compare submitted data with data in storage to determine whether to show credit card doorhanger r=sgalich

https://hg.mozilla.org/mozilla-central/rev/694cac8f2d3d

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox111: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: