1808833 - WARNING: Found a non-root APZ with no handoff parent: file gfx/layers/apz/src/APZCTreeManager.cpp:2887'

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect, P3)

Description

[Hiroyuki Ikezoe (:hiro)]

STR;

1. Open https://bug1796942.bmoattachments.org/attachment.cgi?id=9300038
2. Try to scroll the sub scroller in the page by mouse wheel or pan gesture

Note that there's a wheel event listener calling preventDefault() if the event happens outside of the sub scroller.

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1379458

:dlrobertson, since you are the author of the regressor, bug 1379458, could you take a look?

For more information, please visit auto_nag documentation.

Comment 2

[Dan Robertson (:dlrobertson)]

Attachment: Bug 1808833 - Fix overscroll handoff warning condition. r=botond,hiro

Now that fixed position content will have the mScrollParentId set to the
null scroll parent id, the warning posted for non-root APZC's overscrolled
with a null scroll parent id is no longer valid.

Comment 3

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1379458

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8043d0f12d30
Fix overscroll handoff warning condition. r=botond

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8043d0f12d30

Comment 6

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:dlrobertson, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox110 to wontfix.

For more information, please visit auto_nag documentation.

Comment 7

[Dan Robertson (:dlrobertson)]

How user visible are our warnings? While I'm fairly certain bug 1809574 should be uplifted, I'm don't think this patch needs to be uplifted if a spurious warning is not a big deal.

Comment 8

[Monica Chiorean]

Is there a way I can manually test this? I see no difference in scrolling the link from description between the affected build 110.0a1(20230105213109) and the build with the fix 111.0b8(20230302185836). Thank you.

Comment 9

[Dan Robertson (:dlrobertson)]

(In reply to Monica Chiorean from comment #8)

Is there a way I can manually test this? I see no difference in scrolling the link from description between the affected build 110.0a1(20230105213109) and the build with the fix 111.0b8(20230302185836). Thank you.

You could see a WARNING line in your terminal if you follow the STR with a bad build.