1808840 - Fix non-single buffer mode SurfaceTexture handling of RenderAndroidSurfaceTextureHost with WebRender(Software OpenGL)

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Sotaro Ikeda [:sotaro]]

When SurfaceTexture is not single buffer mode, RenderAndroidSurfaceTextureHost does not call mSurfTex->UpdateTexImage() during rendering with WebRender(Software OpenGL).

On Android Emulator, multi buffer mode SurfaceTexture is used for WebGL SharedSurface.

• https://searchfox.org/mozilla-central/rev/4ebfb48f7e82251145afa4a822f970931dd06c68/gfx/gl/SharedSurfaceEGL.cpp#141

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1808840 - Fix non-single buffer mode SurfaceTexture handling of RenderAndroidSurfaceTextureHost with WebRender(Software OpenGL)

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/397c9cd6a5e3
Fix non-single buffer mode SurfaceTexture handling of RenderAndroidSurfaceTextureHost with WebRender(Software OpenGL) r=gfx-reviewers,lsalzman,jnicol

Comment 3

[Iulian Moraru]

Backed out for causing wr failures on imageBitmapRendering-transferFromImageBitmap-webgl.html.

Push with failures

Failure log

Backout link

Comment 4

[Sotaro Ikeda [:sotaro]]

It seems that we need to mark imageBitmapRendering-transferFromImageBitmap-webgl.html as PASS.

Comment 5

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #4)

It seems that we need to mark imageBitmapRendering-transferFromImageBitmap-webgl.html as PASS.

It addressed the problem.

https://treeherder.mozilla.org/jobs?repo=try&selectedTaskRun=boL4-mSMQgScE8-HGP5zkA.0&revision=6a918e7402ec05a1a16d9ca3604252439531ba00

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5398e3f1b6d7
Fix non-single buffer mode SurfaceTexture handling of RenderAndroidSurfaceTextureHost with WebRender(Software OpenGL) r=gfx-reviewers,lsalzman,jnicol

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/5398e3f1b6d7