1808870 - Remove stylesheet legacy listener and related frontend code

Status: RESOLVED FIXED

(DevTools :: Style Editor, task)

Description

[Julian Descottes [:jdescottes]]

All toolboxes using stylesheets now use the watcher so we can drop the legacy listener and use the watcher instead.

We can also remove individual code branches which are checking if the stylesheet watcher is supported: eg hasStyleSheetWatcherSupport in the server side, and hasResourceCommandSupport for resourceCommand.TYPES.STYLESHEET on the frontend

We might also be able to remove some parts of the actor implementation if some features are now 100% handled by the watcher + stylesheets-manager codepath

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1808870 - [devtools] Remove stylesheet legacy listener

The legacy listener for stylesheets should no longer be needed on any configuration

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1808870 - [devtools] Remove unused media-rules-changed event and getMediaRules

Depends on D166139

This is one of the easiest actors to unplug, and it has very little connections to the rest, so doing it early in the stack

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1808870 - [devtools] Remove mediarule actor

Depends on D166141
Quick followup, we can fully remove the actor.

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1808870 - [devtools] Remove unused code branches behind hasStyleSheetWatcherSupport

Depends on D166142

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1808870 - [devtools] Remove frontend codepath only relevant when stylesheet watcher was disabled

Depends on D166143

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1808870 - [devtools] Remove the stylesheet actor

Depends on D166144

Comment 8

[Julian Descottes [:jdescottes]]

Attachment: Bug 1808870 - [devtools] Move UPDATE_PRESERVING_RULES and UPDATE_GENERAL constants to stylesheets-manager

Depends on D166146

Comment 9

[Julian Descottes [:jdescottes]]

Attachment: Bug 1808870 - [devtools] Move getSheetOwnerNode to stylesheets-manager and delete actors/style-sheet.js

Depends on D166310

Comment 10

[Julian Descottes [:jdescottes]]

Attachment: Bug 1808870 - [devtools] Rename all occurrences of styleSheetManager to styleSheetsManager

Comment 11

[Julian Descottes [:jdescottes]]

Attachment: Bug 1808870 - [devtools] Fix bug number in comments about constructed stylesheets

Depends on D166312

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09b5da592a13
[devtools] Remove stylesheet legacy listener r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/0fc18da9c9b1
[devtools] Remove unused media-rules-changed event and getMediaRules r=devtools-reviewers,devtools-backward-compat-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/f3284760089c
[devtools] Remove mediarule actor r=devtools-reviewers,devtools-backward-compat-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/df38a1ef3e81
[devtools] Remove unused code branches behind hasStyleSheetWatcherSupport r=devtools-reviewers,devtools-backward-compat-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/07b9748fb937
[devtools] Remove frontend codepath only relevant when stylesheet watcher was disabled r=devtools-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/8643fa86cf89
[devtools] Remove the stylesheet actor r=devtools-reviewers,devtools-backward-compat-reviewers,nchevobbe
https://hg.mozilla.org/integration/autoland/rev/566d99ce4023
[devtools] Move UPDATE_PRESERVING_RULES and UPDATE_GENERAL constants to stylesheets-manager r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/727881629f0a
[devtools] Move getSheetOwnerNode to stylesheets-manager and delete actors/style-sheet.js r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/0de387a149e8
[devtools] Rename all occurrences of styleSheetManager to styleSheetsManager r=nchevobbe
https://hg.mozilla.org/integration/autoland/rev/e77ae764df90
[devtools] Fix bug number in comments about constructed stylesheets r=nchevobbe

Comment 13

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/09b5da592a13
https://hg.mozilla.org/mozilla-central/rev/0fc18da9c9b1
https://hg.mozilla.org/mozilla-central/rev/f3284760089c
https://hg.mozilla.org/mozilla-central/rev/df38a1ef3e81
https://hg.mozilla.org/mozilla-central/rev/07b9748fb937
https://hg.mozilla.org/mozilla-central/rev/8643fa86cf89
https://hg.mozilla.org/mozilla-central/rev/566d99ce4023
https://hg.mozilla.org/mozilla-central/rev/727881629f0a
https://hg.mozilla.org/mozilla-central/rev/0de387a149e8
https://hg.mozilla.org/mozilla-central/rev/e77ae764df90