1808989 - Duplicate stream ids in a=msid if addTrack/addTransceiver have duplicates in the associated stream list

Status: RESOLVED FIXED

(Core :: WebRTC: Signaling, defect, P3)

Description

[Byron Campen [:bwc]]

We should be pruning the duplicate ids.

Comment 1

[Byron Campen [:bwc]]

Attachment: Bug 1808989: Remove duplicate msids in RTCRtpSender.setStreams. r?jib

Depends on D168560

Comment 2

[Byron Campen [:bwc]]

https://treeherder.mozilla.org/jobs?repo=try&revision=362a9aa6bf755b613a37fd3a6afe421ec15f191c
https://treeherder.mozilla.org/jobs?repo=try&revision=1f237ae4a89a9294da66175451ff275ab9672243

Comment 3

[Byron Campen [:bwc]]

Try looks fine.

Comment 4

[Byron Campen [:bwc]]

Attachment: Bug 1808989: Test-cases for bug. r?jib

Depends on D168560

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d69211c46c57
Test-cases for bug. r=jib
https://hg.mozilla.org/integration/autoland/rev/6e36d750e4e1
Remove duplicate msids in RTCRtpSender.setStreams. r=jib

Comment 6

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38508 for changes under testing/web-platform/tests

Comment 7

[Cristian Tuns]

Backed out for causing build bustages on PeerConnectionImpl.cpp

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/dom/media/webrtc/jsapi/PeerConnectionImpl.cpp:2024:38: error: unused variable 'id' [-Werror=unused-variable]

mochitest log: https://treeherder.mozilla.org/logviewer?job_id=405685822&repo=autoland

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb48f428f377
Test-cases for bug. r=jib
https://hg.mozilla.org/integration/autoland/rev/d8ad59528a79
Remove duplicate msids in RTCRtpSender.setStreams. r=jib

Comment 10

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38530 for changes under testing/web-platform/tests

Comment 11

[Sandor Molnar[:smolnar]]

Backed out for causing wpt failures in

Backout link: https://hg.mozilla.org/integration/autoland/rev/19e0bc283894a3bf801c7edb6c73879c3aeec836

Push with failures

Failure log #1 | TEST-UNEXPECTED-TIMEOUT | /webrtc/RTCPeerConnection-remote-track-mute.https.html | pc.close() on one side causes mute events on the other - Test timed out

Failure log #2 | TEST-FAIL | /webrtc/RTCPeerConnection-getStats.https.html | getStats() audio and video validate all mandatory stats - assert_equals: Expect dictionary.transportId to be string expected "string" but got "undefined"

Failure log #3 | TEST-UNEXPECTED-FAIL | /webrtc/RTCPeerConnection-getStats.https.html | getStats() on track associated with RTCRtpReceiver should return stats report containing inbound-rtp stats - assert_unreached: required stats <...>

Comment 12

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:bwc, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f16c1067ffe3
Test-cases for bug. r=jib
https://hg.mozilla.org/integration/autoland/rev/1c3a2ac0d63f
Remove duplicate msids in RTCRtpSender.setStreams. r=jib

Comment 15

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38984 for changes under testing/web-platform/tests

Comment 16

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/f16c1067ffe3
https://hg.mozilla.org/mozilla-central/rev/1c3a2ac0d63f

Comment 17

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot