Explicitly close all registered RemoteQuotaObjectParents in FileSystemManagerParent::ActorDestroy
Categories
(Core :: DOM: File, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox111 | --- | fixed |
People
(Reporter: janv, Assigned: janv)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
We currently delay the unregistration of FileSystemManagerParent from FileSystemDataManager until all RemoteQuotaObjectParent objects are unregistered from FileSystemManagerParent to make sure that canonical quota objects are released before we let FileSystemDataManager begin its closing which releases the directory lock in the end. This works fine, but the code can be simpler because we actually don't have to wait for the async close of the PRemoteQuotaObject protocol triggered by the content. We can call Close on all registered RemoteQuotaObjectParent objects in FileSystemManagerParent::ActorDestroy which will synchronously call RemoteQuotaObjectParent::ActorDestroy which releases the canonical quota object. It's not a problem that sometimes the PRemoteQuotaObject protocol will be closed from both ends. IPC internal code can deal with such race.
|
Assignee | |
Updated•1 year ago
|
|
|
Assignee | |
Updated•1 year ago
|
|
|
Assignee | |
Comment 1•1 year ago
|
||
Depends on D166272
|
|
Assignee | |
Comment 2•1 year ago
|
||
Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fd1878fc19b9 Add DEBUGONLY macro; r=dom-storage-reviewers,jari https://hg.mozilla.org/integration/autoland/rev/acd05f9f45fa Explicitly close all registered RemoteQuotaObjectParents in FileSystemManagerParent::ActorDestroy; r=dom-storage-reviewers,jari
|
||
Comment 4•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/fd1878fc19b9
https://hg.mozilla.org/mozilla-central/rev/acd05f9f45fa
Description
•