1809035 - Explicitly close all registered RemoteQuotaObjectParents in FileSystemManagerParent::ActorDestroy

Status: RESOLVED FIXED

(Core :: DOM: File, task, P2)

Description

[Jan Varga [:janv]]

We currently delay the unregistration of FileSystemManagerParent from FileSystemDataManager until all RemoteQuotaObjectParent objects are unregistered from FileSystemManagerParent to make sure that canonical quota objects are released before we let FileSystemDataManager begin its closing which releases the directory lock in the end. This works fine, but the code can be simpler because we actually don't have to wait for the async close of the PRemoteQuotaObject protocol triggered by the content. We can call Close on all registered RemoteQuotaObjectParent objects in FileSystemManagerParent::ActorDestroy which will synchronously call RemoteQuotaObjectParent::ActorDestroy which releases the canonical quota object. It's not a problem that sometimes the PRemoteQuotaObject protocol will be closed from both ends. IPC internal code can deal with such race.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1809035 - Explicitly close all registered RemoteQuotaObjectParents in FileSystemManagerParent::ActorDestroy; r=#dom-storage

Depends on D166272

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1809035 - Add DEBUGONLY macro; r=#dom-storage

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd1878fc19b9
Add DEBUGONLY macro; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/acd05f9f45fa
Explicitly close all registered RemoteQuotaObjectParents in FileSystemManagerParent::ActorDestroy; r=dom-storage-reviewers,jari

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/fd1878fc19b9
https://hg.mozilla.org/mozilla-central/rev/acd05f9f45fa