1809043 - Close RemoteQuotaObjectParent during access handle closing in the parent process

Status: RESOLVED FIXED

(Core :: DOM: File, task, P2)

Description

[Jan Varga [:janv]]

After bug 1809035, RemoteQuotaObjectParent objects will be closed in FileSystemManagerParent::ActorDestroy. We plan to verify the file in RemoteQuotaObjectParent::ActorDestroy and potentially change the size of the file. If we keep closing RemoteQuotaObjectParent objects in FileSystemManagerParent::ActorDestroy then we might record wrong size of the file in the database (for quota management purposes) because the new file size is updated in FileSystemDataManager::UnlockExclusive which is called from FileSystemAccessHandleParent::Close and the top level actor is always destroyed after actors for subprotocols. So RemoteQuotaObjectParent objects need to be closed during access handle closing in the parent process.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1809043 - Make FileSystemDataManager ref counting thredsafe; r=#dom-storage

The destructor still has to run on the owning thread.

Depends on D166273

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1809043 - Create a dedicated parent object for access handles independent from IPC; r=#dom-storage

Parent objects are usually actors as well, but the access handle is special
because it will need to have multiple actors.

Depends on D166297

Comment 3

[Jan Varga [:janv]]

Attachment: Bug 1809043 - Prepare FileSystemAccessHandle for asynchronous closing; r=#dom-storage

Asynchronous closing can't be triggered from the destructor because it needs to
add a strong ref to self.

Depends on D166298

Comment 4

[Jan Varga [:janv]]

Attachment: Bug 1809043 - Prepare FileSystemAccessHandle for asynchronous creation; r=#dom-storage

FileSystemAccessHandle::Create now returns a MozPromise, but the creation does
nothing on other threads for now.

Depends on D166299

Comment 5

[Jan Varga [:janv]]

Attachment: Bug 1809043 - Register active FileSystemAccessHandles in FileSystemDataManager; r=#dom-storage

Active FileSystemAccessHandles will prevent FileSystemDataManager from closing.

Depends on D166300

Comment 6

[Jan Varga [:janv]]

Attachment: Bug 1809043 - Close RemoteQuotaObjectParent during access handle closing in the parent process; r=#dom-storage

Depends on D166301

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a864bf574db
Make FileSystemDataManager ref counting thredsafe; r=dom-storage-reviewers,jari

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb987c82fdda
Create a dedicated parent object for access handles independent from IPC; r=dom-storage-reviewers,jari

Comment 9

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/9a864bf574db
https://hg.mozilla.org/mozilla-central/rev/cb987c82fdda

Comment 10

[Jan Varga [:janv]]

https://treeherder.mozilla.org/jobs?repo=try&revision=5b00f54f9e685aa2fc958614442c72124b0fb6a3

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7f6f2e321e73
Prepare FileSystemAccessHandle for asynchronous closing; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/8d99cca8f722
Prepare FileSystemAccessHandle for asynchronous creation; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/d7ef9833e3cc
Register active FileSystemAccessHandles in FileSystemDataManager; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/59847b64b45d
Close RemoteQuotaObjectParent during access handle closing in the parent process; r=dom-storage-reviewers,jari

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7f6f2e321e73
https://hg.mozilla.org/mozilla-central/rev/8d99cca8f722
https://hg.mozilla.org/mozilla-central/rev/d7ef9833e3cc
https://hg.mozilla.org/mozilla-central/rev/59847b64b45d