Close RemoteQuotaObjectParent during access handle closing in the parent process
Categories
(Core :: DOM: File, task, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox111 | --- | fixed |
People
(Reporter: janv, Assigned: janv)
References
(Blocks 1 open bug)
Details
Attachments
(6 files)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review |
After bug 1809035, RemoteQuotaObjectParent objects will be closed in FileSystemManagerParent::ActorDestroy. We plan to verify the file in RemoteQuotaObjectParent::ActorDestroy and potentially change the size of the file. If we keep closing RemoteQuotaObjectParent objects in FileSystemManagerParent::ActorDestroy then we might record wrong size of the file in the database (for quota management purposes) because the new file size is updated in FileSystemDataManager::UnlockExclusive which is called from FileSystemAccessHandleParent::Close and the top level actor is always destroyed after actors for subprotocols. So RemoteQuotaObjectParent objects need to be closed during access handle closing in the parent process.
Assignee | ||
Comment 1•9 months ago
|
||
The destructor still has to run on the owning thread.
Depends on D166273
Assignee | ||
Comment 2•9 months ago
|
||
Parent objects are usually actors as well, but the access handle is special
because it will need to have multiple actors.
Depends on D166297
Assignee | ||
Comment 3•9 months ago
|
||
Asynchronous closing can't be triggered from the destructor because it needs to
add a strong ref to self.
Depends on D166298
Assignee | ||
Comment 4•9 months ago
|
||
FileSystemAccessHandle::Create now returns a MozPromise, but the creation does
nothing on other threads for now.
Depends on D166299
Assignee | ||
Comment 5•9 months ago
|
||
Active FileSystemAccessHandles will prevent FileSystemDataManager from closing.
Depends on D166300
Assignee | ||
Comment 6•9 months ago
|
||
Depends on D166301
Assignee | ||
Updated•8 months ago
|
Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9a864bf574db Make FileSystemDataManager ref counting thredsafe; r=dom-storage-reviewers,jari
Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cb987c82fdda Create a dedicated parent object for access handles independent from IPC; r=dom-storage-reviewers,jari
Comment 9•8 months ago
|
||
bugherder |
Assignee | ||
Comment 10•8 months ago
|
||
Assignee | ||
Updated•8 months ago
|
Comment 11•8 months ago
|
||
Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7f6f2e321e73 Prepare FileSystemAccessHandle for asynchronous closing; r=dom-storage-reviewers,jari https://hg.mozilla.org/integration/autoland/rev/8d99cca8f722 Prepare FileSystemAccessHandle for asynchronous creation; r=dom-storage-reviewers,jari https://hg.mozilla.org/integration/autoland/rev/d7ef9833e3cc Register active FileSystemAccessHandles in FileSystemDataManager; r=dom-storage-reviewers,jari https://hg.mozilla.org/integration/autoland/rev/59847b64b45d Close RemoteQuotaObjectParent during access handle closing in the parent process; r=dom-storage-reviewers,jari
Comment 12•8 months ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/7f6f2e321e73
https://hg.mozilla.org/mozilla-central/rev/8d99cca8f722
https://hg.mozilla.org/mozilla-central/rev/d7ef9833e3cc
https://hg.mozilla.org/mozilla-central/rev/59847b64b45d
Description
•