1809044 - Implement WorkerEventTarget::RegisterShutdownTask and WorkerEventTarget::UnregisterShutdownTask

Status: RESOLVED FIXED

(Core :: DOM: Workers, task, P2)

Description

[Jan Varga [:janv]]

We need to create a new top level protocol for sync access handles which will bind the child side to WorkerPrivate::ControlEventTarget. The binding currently fails because WorkerEventTarget::RegisterShutdownTask and WorkerEventTarget::UnregisterShutdownTask are not implemented.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

If we're going to be using the ControlEventTarget for IPC stuff we should probably make sure to poison[1] the worker global via nsIGlobalObject::StartForbiddingScript/StopForbiddingScript via WorkerGlobalScopeBase::WorkerPrivateSaysForbidScript/WorkerPrivateSaysAllowScript while we're processing control runnables to avoid situations where code might erroneously/accidentally try and call into content from a control runnable.

1: Well, it's not entirely poisoning because we won't crash or anything, but it will make sure we don't call into content. (We will ThrowNotSupportedError though, but only the thing trying to call into content will see that, and frequently those don't do much with it.)

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1809044 - Implement WorkerEventTarget::RegisterShutdownTask and WorkerEventTarget::UnregisterShutdownTask; r=#dom-workers

Depends on D166302

Comment 3

[Jan Varga [:janv]]

This is now used in D166344. See the FileSystemSyncAccessHandle::BeginClose method, mControlActor is bound to WorkerPrivate::ControlEventTarget and it's just used for sending the close message to the parent and waiting for a response.

Comment 4

[Jan Varga [:janv]]

(In reply to Andrew Sutherland [:asuth] (he/him) from comment #1)

If we're going to be using the ControlEventTarget for IPC stuff we should probably make sure to poison[1] the worker global via nsIGlobalObject::StartForbiddingScript/StopForbiddingScript

I added something like that in https://phabricator.services.mozilla.com/D166344?vs=666165&id=666226#toc

Comment 5

[Jan Varga [:janv]]

https://treeherder.mozilla.org/jobs?repo=try&revision=a9cb5f173dd02cd1a231a9274f2ce403cda25968

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9bb0f824a2d8
Implement WorkerEventTarget::RegisterShutdownTask and WorkerEventTarget::UnregisterShutdownTask; r=dom-worker-reviewers,asuth

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/9bb0f824a2d8