1809057 - Make sure all sizemode changes do go through FrameState::SetSizeModeInternal

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1809057 - Make sure all sizemode changes do go through FrameState::SetSizeModeInternal. r=rkraesig,cmartin

I wrote this while debugging / fixing bug 1806438, but this is kind of
orthogonal. Instead of doing it using a member variable like I did
initially, let's just be explicit and pass whether we need ShowWindow()
etc done as part of the arguments to EnsureSizeMode and co.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1de22258a95c
Make sure all sizemode changes do go through FrameState::SetSizeModeInternal. r=rkraesig

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be4ba160f2a9
Do the ShowWindowAndFocus::No on the right message.

Comment 4

[Noemi Erli[:noemi_erli]]

Backed out 2 changesets (Bug 1809057) for causing failures in browser_startup_flicker.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=windows%2C10%2Cx64%2C2004%2Casan%2Cwebrender%2Copt%2Cmochitests%2Ctest-windows10-64-2004-asan-qr%2Fopt-mochitest-browser-chrome%2Cbc4&revision=be4ba160f2a9120f52469d9e1e44428bc5c32b61&selectedTaskRun=BkLxJ_3hRCa2ydgT68YXGg.0

Log: https://treeherder.mozilla.org/logviewer?job_id=401992985&repo=autoland&lineNumber=2572

Backout: https://treeherder.mozilla.org/jobs?repo=autoland&revision=66c42cef8816a3264963ad03ee2dc74cead27fef

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The following field has been copied from a duplicate bug:

Field	Value	Source
Regressed by	bug 1800416	bug 1809757

For more information, please visit auto_nag documentation.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

This bug has the keyword regression, so its type should be defect.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4debd5a21cd9
Make sure all sizemode changes do go through FrameState::SetSizeModeInternal. r=rkraesig

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aab34aaa9876
Make sure all sizemode changes do go through FrameState::SetSizeModeInternal. r=rkraesig

Comment 10

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/874c16494039
Backed out changeset 4debd5a21cd9 for causing bc windows failures on browser_test_data_text_csv.js. CLOSED TREE

Comment 11

[Cosmin Sabou [:CosminS]]

Nevermind comment 10, it was due to a wrong copy of the revision number for another backout. The patch was relanded in comment 9.

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Phew, thanks Cosmin!

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1800416

Comment 14

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/aab34aaa9876

Comment 15

[Pascal Chevrel:pascalc (PTO until April 26)]

Is that something that would benefit our 110 release with an uplift or can it ride the 111 train? Thanks

Comment 16

[Emilio Cobos Álvarez (:emilio)]

This is historically rather tricky code, so I'd rather let it ride the trains.

Comment 17

[Pascal Chevrel:pascalc (PTO until April 26)]

Thanks!