1809119 - Autocompletion in Browser Console does not seem to pick the right target

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. Open the Browser Console
2. in the context selector, select a Content Process target (one prefixed with (pid XXX))
3. evaluate globalThis.myProp = "hello"
4. Type globalThis.my

Expected results

The completion text shows globalThis.myProp

Actual results

The completion text does not show globalThis.myProp

---

This is not that the property is not set, because evaluating globalThis.myProp does return "hello" (and I spotted this earlier because I was able to autocomplete console. although console is undefined in this context)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

I missed this when I added the context selector in the Browser Console (Bug 1780156)

https://searchfox.org/mozilla-central/rev/d62c4c4d5547064487006a1506287da394b64724/devtools/client/webconsole/actions/autocomplete.js#246-250

// Note that getSelectedTargetFront will return null if we default to the top level target.
// For now, in the browser console (without a toolbox), we don't support the context selector.
const contextSelectorTargetFront = hud.toolbox
  ? hud.toolbox.getSelectedTargetFront()
  : null;

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1809119 - [devtools] Use selected target in context selector for Browser Console autocomplete. r=ochameau.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba1f5fb251fd
[devtools] Use selected target in context selector for Browser Console autocomplete. r=ochameau.

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ba1f5fb251fd