1809136 - Cookie Banner Reduction Re-Engagement Dialog is not displayed again after tapping "Not Now" option

Status: VERIFIED FIXED

(Firefox for Android :: Privacy, defect, P2)

Description

[Andrei Mocirean]

From github: https://github.com/mozilla-mobile/fenix/issues/28461.

Preconditions

• Have a clean installed build

Steps to reproduce

1. Open Firefox.
2. Go to Amazon.de
3. When prompted by the Re-Engagement pop-up, tap on "Not Now".
4. Change the device's time to 4 hours ahead.
5. Open Firefox and go to Amazon.de.
6. Observe

Expected behaviour

The dialog should be displayed again upon accessing a website containing cookie banners.

Actual behaviour

The dialog is not displayed again.

Device name

Google Pixel 6

Android version

Android 13

Firefox release type

Firefox Nightly

Firefox version

110.0a1

Device logs

No response

Additional information

Tested on: Google Pixel 6 (Android 13), Samsung Galaxy S22 Ultra (Android 13), Oppo Find X5 (Android 12), Huawei P40 Lite (Android 10).

Also tested with a 24h ahead timestamp and the result is the same.

https://user-images.githubusercontent.com/103257761/211300428-574c143c-d0bf-4430-b919-98045a9cc004.mp4

Change performed by the Move to Bugzilla add-on.

Comment 1

[BMO Automation]

Attachment: [mozilla-mobile/fenix] Bug 1809136 - Address CookieBannerReEngagementDialog not showing after expired timer (#28506)

Comment 2

[Arturo Mejia [:amejia]]

This landed on the main branch via https://github.com/mozilla-mobile/fenix/pull/28506 validated manually.

Comment 3

[Andrei Mocirean]

Verified as fixed on the latest Nightly 112.0a1 (22th of February 2023).

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit auto_nag documentation.

Comment 5

[Chris Peterson [:cpeterson]]

Arturo, do we need to uplift this cookie banner fix to Beta 111 for the CBH experiment planned for Fenix 111?

Comment 6

[Arturo Mejia [:amejia]]

(In reply to Chris Peterson [:cpeterson] from comment #5)

Arturo, do we need to uplift this cookie banner fix to Beta 111 for the CBH experiment planned for Fenix 111?

No, it's more for the behaviour of v112 and up, as we are enabling this on [nightly 112] (https://github.com/mozilla-mobile/firefox-android/commit/ed9eb6454ae54cc3288e9a520b0dd4bb0ef7771e)

Comment 7

[Arturo Mejia [:amejia]]

Sorry, I got confused with bug 1818056. But we don't need to uplift as the patch is already on v111

Comment 8

[Chris Peterson [:cpeterson]]

(In reply to Arturo Mejia [:amejia] from comment #7)

Sorry, I got confused with bug 1818056. But we don't need to uplift as the patch is already on v111

Cool. In that case, I'll set firefox111's tracking flag = fixed.