1809180 - Inline more array builtins with a callback argument

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task)

Description

[Jan de Mooij [:jandem]]

We call SetIsInlinableLargeFunction for ArrayMap and ArrayForEach, but not for ArrayFilter and ArrayFind{Index,Last,LastIndex}. We should probably treat those the same way.

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Bug 1809180 part 1 - Remove some unnecessary vars in self-hosted code. r?iain!

This matches code in other builtins and shrinks the bytecode a little.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Bug 1809180 part 2 - Mark {Typed}Array find/filter builtins as inlinable. r?iain!

This matches map, some, forEach, etc.

Depends on D166639

Comment 3

[Jan de Mooij [:jandem]]

This micro-benchmark for Array.prototype.filter improves from ~312 ms to ~163 ms:

function f() {
  var arr = Array(100).fill(123);
  var res;
  var t = new Date;
  for (var i = 0; i < 100_000; i++) {
    res = arr.filter(x => x > 100).filter(x => x > 120).filter(x => x < 0);
  }
  print(new Date - t);
  return res;
}
f();

And this one for %TypedArray%.prototype.findIndex from ~193 ms to ~54 ms:

function f() {
  var ta = new Int32Array(100);
  ta[90] = 123;
  var res;
  var t = new Date;
  for (var i = 0; i < 100_000; i++) {
    res = ta.findIndex(x => x > 0) + ta.findIndex(x => x < 0) + ta.findIndex(x => x === 123);
  }
  print(new Date - t);
  return res;
}
f();

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49832385a669
part 1 - Remove some unnecessary vars in self-hosted code. r=iain
https://hg.mozilla.org/integration/autoland/rev/67187d488af1
part 2 - Mark {Typed}Array find/filter builtins as inlinable. r=iain

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/49832385a669
https://hg.mozilla.org/mozilla-central/rev/67187d488af1