Closed Bug 1809205 Opened 1 year ago Closed 1 year ago

Some of the font-variation-settings-composition.html subtests fail (spuriously)

Categories

(Core :: CSS Parsing and Computation, defect)

All
Unspecified
defect

Tracking

()

RESOLVED FIXED
111 Branch
Tracking Status
firefox111 --- fixed

People

(Reporter: jfkthame, Assigned: jfkthame)

Details

Attachments

(1 file)

I notice that we're currently showing a bunch of failures in font-variation-settings-composition.html.

The failures occur in the testcases that involve a font-variation-settings value that lists two <axis, value> pairs. This looks like it's actually a flawed assumption in the test: it assumes the serialized value of font-variation-settings will be in a certain order. But there's no spec requirement for this, and no reason it should be so. The values are an unordered set, so any serialization order should be equivalent.

Therefore, I think we should fix the test so that it doesn't care about the order. A simple way to do this is to just split the list into elements and sort them prior to doing the comparison.

Variation axis-value pairs are an unordered set, not an ordered list, so the test should not be
requiring any particular ordering in the serialization. The order we get when we serialize the
interpolated value is arbitrary, and that's OK.

Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ab8231120690
Make css-fonts/animations/font-variation-settings-composition.html less finicky about serialization order for font-variation-settings. r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/38011 for changes under testing/web-platform/tests
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
Upstream PR merged by moz-wptsync-bot
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: