1809223 - [wpt-sync] Sync PR 37814 - Do not fire `beforetoggle` asynchronously

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 37814 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/37814
Details from upstream follow.

Mason Freed <[e-mail]> wrote:

Do not fire beforetoggle asynchronously

Per the discussion at [1], we have decided not to fire async
beforetoggle events at all. This means that no event will be fired
in this case:

myPopover.showPopover();
myPopover.remove();

[1] https://github.com/whatwg/html/pull/8221#discussion_r1049368041

Bug: 1307772
Change-Id: Ie6d0f24f1181131fd6e15732020c0575cd3ba865
Reviewed-on: https://chromium-review.googlesource.com/4146026
WPT-Export-Revision: 5967c2e87b38b6c65d7ca76d85721c5cf5da7630

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=6780780057367276f9078173a341a2d884637faf

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 10 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 4 subtests

Status Summary

Firefox

OK : 1
FAIL : 4

Chrome

PASS : 4
ERROR: 1

Safari

OK : 1
FAIL : 4

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/popovers/popover-events.tentative.html [wpt.fyi]
  • Beforetoggle event (listener) get properly dispatched for popovers: FAIL (Chrome: PASS, Safari: FAIL)
  • Beforetoggle event (attribute) get properly dispatched for popovers: FAIL (Chrome: PASS, Safari: FAIL)
  • Beforetoggle event is cancelable for the "opening" transition: FAIL (Chrome: PASS, Safari: FAIL)
  • Beforetoggle event is not fired for element removal: FAIL (Chrome: PASS, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e4a8cf768425
[wpt PR 37814] - Do not fire `beforetoggle` asynchronously, a=testonly
https://hg.mozilla.org/integration/autoland/rev/00f01983f19b
[wpt PR 37814] - Update wpt metadata, a=testonly

Comment 4

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/e4a8cf768425
https://hg.mozilla.org/mozilla-central/rev/00f01983f19b