1809306 - "Copy Link" context menu copies title instead of URL for HTML5 Video

Status: VERIFIED FIXED

(Firefox for Android :: Browser Engine, defect, P1)

Description

[Christian Sadilek [:csadilek]]

From github: https://github.com/mozilla-mobile/fenix/issues/18979.

Steps to reproduce

1. Find an HTML5 video on the Internet. Sample one on this page
   https://www.edcint.co.nz/public/data/firefox/index.shtml
2. Long press video (context menu appears)
3. tap "Copy Link"
4. go to a place/app where you can paste, then paste the link you copied

Expected behavior

the URL of the video is pasted (as experienced in the Windows desktop version of Firefox from the "Copy Video Location" context menu)

Actual behavior

the title attribute of the video is pasted

Device information

v87.0.0-rc.1 Build#2015799099

┆Issue is synchronized with this Jira Task

Change performed by the Move to Bugzilla add-on.

Comment 1

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:cpeterson, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[jackyzy823]

Ref:
android-components/components/feature/contextmenu/src/main/java/mozilla/components/feature/contextmenu/ContextMenuCandidate.kt

internal fun HitResult.getLink(): String = when (this) {
    is HitResult.UNKNOWN -> src
    is HitResult.IMAGE_SRC -> uri
    is HitResult.IMAGE ->
        if (title.isNullOrBlank()) {
            src.takeOrReplace(MAX_TITLE_LENGTH, "image")
        } else {
            title.toString()
        }
    is HitResult.VIDEO ->
        if (title.isNullOrBlank()) src else title.toString()
    is HitResult.AUDIO ->
        if (title.isNullOrBlank()) src else title.toString()
    else -> "about:blank"
}

Currently , so if is VIDEO and title is not null , use title.
We should divide this to "Copy Link" and "Copy Link Text".

Comment 3

[Chris Peterson [:cpeterson]]

Jeff says this would be easy to fix. We only want to copy the link URL, not the link text.

Comment 4

[Chris Peterson [:cpeterson]]

Clearing Priority so we can reprioritize these bugs relative to our ux-fun-2024 bugs.

Comment 7

[BugBot [:suhaib / :marco]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:boek, since the bug has high priority and recent activity, could you have a look please?

For more information, please visit BugBot documentation.

Comment 8

[Alexandra Virvara]

Attachment: Bug 1809306: copy link context menu should copy the url, not the title of the video

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/dcf1a6e71ada
https://hg.mozilla.org/integration/autoland/rev/2c63cd0c9256
copy link context menu should copy the url, not the title of the video r=android-reviewers,matt-tighe

Comment 10

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/2c63cd0c9256

Comment 11

[Mira Lobontiu (Android QA)]

Verified as fixed on the latest Firefox for Android Nightly 144.0a1 from 9/13 with a Samsung Galaxy S24 (Android 15), and an OnePlus 5T (Android 10).