1809331 - add more fxms-message-* feature ids to FeatureManifest.json and ASRouter

Status: RESOLVED FIXED

(Firefox :: Nimbus Desktop Client, task, P1)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Product would like to deploy experiment/rollout pairs for a couple of onboarding messages in 109 Release that are expected (based on previous experiments & rollouts) to positively affect various combinations of pinning, setting-to-default, and CDOU.

In order to be able to do this without interfering with other experiments, we will need some more generic fxms-message-* feature IDs to be added to Nimbus and recognized in ASRouter.

This is exceedingly low risk, as it just involves slightly extending a couple of lists of names that already work just fine.

Comment 1

[Dan Mosedale (:dmosedale, :dmose)]

[Tracking Requested - why for this release]:

See comment 0 (the one above this).

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: Bug 1809331 - add generic fxms-message-* feature-ids, r=pdahiya!

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Checked with product; 109.0.1 is fine for this.

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

The schedule for upcoming rollouts has just shifted so that this is no longer planned for 109 release, but 110 release instead, so I'm removing the tracking flags.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

[Tracking Requested - why for this release]:

We'll need more featureIds to do more rollouts on 110 Release.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1aac5676d79
add generic fxms-message-* feature-ids, r=omc-reviewers,emcminn,pdahiya

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b1aac5676d79

Comment 8

[Pascal Chevrel:pascalc]

Dan, please request uplift to beta as we are nearing the end of the beta cycle, thanks!

Comment 9

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 9311462 [details]
Bug 1809331 - add generic fxms-message-* feature-ids, r=pdahiya!

Beta/Release Uplift Approval Request

• User impact if declined: Users will not see features scheduled to be rolled out by the Velocity team to compound usage wins from previous experiments.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is just adding feature ids to two static tables. We've done this in the past and used the results and supporting infrastructure in our successful rollout of Import Bookmarks in December. There is plenty of automatic test coverage of the infrastructure as a whole, though not of each specific entry that gets added to the list. In the exceedingly unlikely case that these feature ids somehow don't work, we would simply not use them (i.e. no change for the user).
• String changes made/needed: None
• Is Android affected?: No

Comment 10

[Pascal Chevrel:pascalc]

Comment on attachment 9311462 [details]
Bug 1809331 - add generic fxms-message-* feature-ids, r=pdahiya!

Approved for 110 beta 8, thanks.

Comment 11

[Pascal Chevrel:pascalc]

https://hg.mozilla.org/releases/mozilla-beta/rev/bfa94aaa1240