Closed Bug 1809393 Opened 2 years ago Closed 2 years ago

Text selection/Find in page does not work well on Xiaomi Pad5 (Android 12)

Categories

(Firefox for Android :: General, defect)

Firefox 110
All
Android
defect

Tracking

()

VERIFIED FIXED
Tracking Status
firefox110 --- wontfix
firefox111 --- verified

People

(Reporter: apetridean, Unassigned)

References

Details

(Whiteboard: [PDF reader])

Attachments

(6 files)

Attached video Select.mp4

Steps to reproduce

  1. In about:config, set the pdfjs.disabled pref to false.
  2. Open a PDF file.
  3. Select a word and tap on Search or Copy.
  4. Observe the behaviour.
  5. Select the "Find in page" option from the 3 dot menu.
  6. Search for a term and observe the results.

Expected behavior

After step 4, the word is selected and copied to clipboard/searched properly.
After step 6 the desired term is highlighted properly.

Actual behavior

The select function does not work well on Xiaomi Pad5 (Android 12) .
After selecting the word and pressing Search, a word/letters that are in front of the desired word are searched. This issue affects also: Copy, Share, WPS Memo features.
For the "Find in Page" feature, the desired term is not highlighted, instead the words/terms that are in front/behind of the desired ones are highlighted.

Device information

  • Firefox version: 110.0a1 from 10.01.2023
  • Android device model: Xiaomi Pad5
  • Android OS version: Android 12

Any additional information?

Please note I can not reproduce this issue on another devices.
Please also note that the issue does not occur when the PDF feature is disabled.

Attached video FindInPage.mp4
Blocks: 1803753

Could you attach the PDF here?

Depends on: 1803188

Unfortunately, the text selection is far from perfect in pdf.js and is a long-standing bug (see bug 1201356).
But for the search part, it should be fixed thanks to bug 1803188.

Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED

Tested on the latest Nightly 111.0a1 (2023-02-01), with Xiaomi Pad5 (Android 12) and this issue is still reproducible ( including the search part).

Please check the new videos attached.

Attached image FindInPage.JPEG
Attached video Search.mp4

(In reply to Calixte Denizet (:calixte) from comment #4)

Unfortunately, the text selection is far from perfect in pdf.js and is a long-standing bug (see bug 1201356).
But for the search part, it should be fixed thanks to bug 1803188.

Given the fact that this issue is device specific, is there anything else that can be done to improve the text selection and text search in PDFs? If not, we will mark this ticket as Verified.

Flags: needinfo?(cdenizet)

This bug is a mix of several issues which are more or less connected:

  • the selected text as it appears on the screen is not always the text as it's in the text layer: this implies that an highlighted word (as a search result) is not always correct or a selected word is not the one which is copied. The gravity of the issue with the text layer directly depends on the font (serif or sans-serif) used in Fenix and this font can be very different from a device to an other.
  • search-in-pdf was not working because when the bug has been filed it wasn't implemented: now it's.
    I understand that the issues with the text layer can make hard to verify that the bug is correctly fixed.
    So to verify if the search-in-pdf is correctly working:
    • you can verify that the position is approximately correct
    • the numbers XX / YY (XX-th occurrence over YY results) are correct.
Flags: needinfo?(cdenizet)

We noticed that it depends on the PDFs, on some search the terms are correctly identified but highlighted near the term itself, while on other PDFs the highlights fall incorrectly.

Please check the new attached videos.

Attached video pdf1.mp4
Attached video pdf2.mp4
Status: RESOLVED → VERIFIED

Too late to uplift to a 110 dot release

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: