1809459 - Use Map instances for UniFFI maps to allow non-string keys.

Status: RESOLVED FIXED

(Toolkit :: UniFFI Bindings, enhancement)

Description

[Ben Dean-Kawamura [:bdk]]

We currently implement maps using plain-old-javascript-objects. This means that all keys must be strings. UniFFI now supports non-string keys, so we should switch to using the Map class which allows for non-strings.

Comment 1

[Drew Willcoxon :adw]

I hit this in a PR I'm working on so I'd like to take a shot at it.

Comment 2

[Drew Willcoxon :adw]

Attachment: Bug 1809459 - Use Map instances for UniFFI maps to allow non-string keys.

Comment 3

[Ben Dean-Kawamura [:bdk]]

Sounds good, have you started on it? I'm trying to land a large refactor of the binding generation, which will make this work easier but it will be pretty disruptive if it lands while you're in the middle of working on this. It's very close to landing, I just need to rebase and fix what's hopefully the last small bug. I'm thinking it'll land today -- although I said that yesterday as well.

Can you base your work on top of that or wait until it lands?

Comment 4

[Ben Dean-Kawamura [:bdk]]

Oh, you're quick. I see the phabricator patch already. No problem, I'll rebase on top of yours.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6cdd123fbdf7
Use Map instances for UniFFI maps to allow non-string keys. r=bdk

Comment 6

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/6cdd123fbdf7