1809512 - Replace waitForCondition() with waitForMutationCondition() in toolkit/content/tests/browser/browser_datetime_datepicker_keynav.js

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, task)

Description

[Anna Yeddi [:ayeddi]]

In toolkit/content/tests/browser/browser_datetime_datepicker_keynav.js replace 2 instances of await BrowserTestUtils.waitForCondition() with await BrowserTestUtils.waitForMutationCondition() per the recommendation from Mike Conley

Comment 1

[Anna Yeddi [:ayeddi]]

Attachment: Bug 1809512 - Use a MutationObserver in two tests in toolkit/content/tests/browser/browser_datetime_datepicker_keynav.js. r=mconley!,Jamie

In toolkit/content/tests/browser/browser_datetime_datepicker_keynav.js replace 2 instances of await BrowserTestUtils.waitForCondition() with await BrowserTestUtils.waitForMutationCondition() per the recommendation, because if possible, we should avoid polling with waitForCondition. If we're waiting for some DOM to change on us, we can use waitForMutationCondition instead, which uses a MutationObserver rather than an interval for polling.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a1eacd09673
Use a MutationObserver in two tests in toolkit/content/tests/browser/browser_datetime_datepicker_keynav.js. r=Jamie,mconley

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/4a1eacd09673