mozcrash.py doesn't ignore some inlined functions in panic stacks and only ever looks at the first 9 frames
Categories
(Testing :: Mozbase, defect)
Tracking
(firefox111 fixed)
| Tracking | Status | |
|---|---|---|
| firefox111 | --- | fixed |
People
(Reporter: gsvelto, Assigned: gsvelto)
References
Details
Attachments
(2 files, 1 obsolete file)
This is what's causing all signatures generated by mozcrash.py to be the same. First of all we don't skip the inlined panic frames correctly. Secondly even when we do skip them we don't find a proper signature if it's in frame 10 or deeper; mozcrash only ever looks at the first 9 frames so that's that.
Naturally we should really be fixing bug 867571 (yay 10yo bug!) instead of piling hacks on mozcrash.py, but since we don't have time for that it'll be hacks again.
|
Assignee | |
Comment 1•1 year ago
|
||
|
||
Updated•1 year ago
|
|
|
||
Updated•1 year ago
|
|
|
Assignee | |
Comment 2•1 year ago
|
||
We also print stderr unconditionally as the new stackwalker isn't as chatty as
the old one.
|
|
Assignee | |
Comment 3•1 year ago
|
||
Depends on D167570
|
|
Assignee | |
Comment 4•1 year ago
|
||
Whoops, I've got something very wrong with the patches. I was in the esr102 branch instead of being on central, I'll rebase them.
|
|
Assignee | |
Comment 5•1 year ago
|
||
Things seem to be working properly even on Windows.
Pushed by gsvelto@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b81900bef876 [mozcrash] Remove support for the Breakpad stackwalker, we use rust-minidump across-the-board r=gbrown https://hg.mozilla.org/integration/autoland/rev/9741cf4a6dd3 [mozcrash] Use JSON output from the rust-minidump stackwalker to generate the signature r=gbrown
|
||
Comment 7•1 year ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b81900bef876
https://hg.mozilla.org/mozilla-central/rev/9741cf4a6dd3
Description
•