1809528 - mozcrash.py doesn't ignore some inlined functions in panic stacks and only ever looks at the first 9 frames

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Gabriele Svelto [:gsvelto]]

This is what's causing all signatures generated by mozcrash.py to be the same. First of all we don't skip the inlined panic frames correctly. Secondly even when we do skip them we don't find a proper signature if it's in frame 10 or deeper; mozcrash only ever looks at the first 9 frames so that's that.

Naturally we should really be fixing bug 867571 (yay 10yo bug!) instead of piling hacks on mozcrash.py, but since we don't have time for that it'll be hacks again.

Comment 1

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1809528 - [mozcrash] Handle inlined panic frames correctly when generating a crash signature r=jlorenzo

Comment 2

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1809528 - [mozcrash] Remove support for the Breakpad stackwalker, we use rust-minidump across-the-board r=gbrown

We also print stderr unconditionally as the new stackwalker isn't as chatty as
the old one.

Comment 3

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1809528 - [mozcrash] Use JSON output from the rust-minidump stackwalker to generate the signature r=gbrown

Depends on D167570

Comment 4

[Gabriele Svelto [:gsvelto]]

Whoops, I've got something very wrong with the patches. I was in the esr102 branch instead of being on central, I'll rebase them.

Comment 5

[Gabriele Svelto [:gsvelto]]

Things seem to be working properly even on Windows.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b81900bef876
[mozcrash] Remove support for the Breakpad stackwalker, we use rust-minidump across-the-board r=gbrown
https://hg.mozilla.org/integration/autoland/rev/9741cf4a6dd3
[mozcrash] Use JSON output from the rust-minidump stackwalker to generate the signature r=gbrown

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b81900bef876
https://hg.mozilla.org/mozilla-central/rev/9741cf4a6dd3