1809570 - Add codec software/hardware decode status display in about:support for Android.

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[az [:az]]

This work required more substantial changes than expected, including to the interface to the Android API used to collect codec support information in Android PDMs over JNI. Several utility functions were added to help with this, including functions to collect HW accelerated decode support information in bulk. A full summary of the changes in depth can be found in the summary of this patch.

Comment 1

[az [:az]]

Attachment: Bug 1809570 - Part 1 - Add utility functions to convert between MIME type strings and codec SW/HW support enums. r=jolin

Comment 2

[az [:az]]

Attachment: WIP: Bug 1809570 - Add utility functions to distinguish between SW/HW codec support on Android r=jolin

Comment 3

[az [:az]]

Attachment: Bug 1809570 - Part 2 - Request and process per-codec SW/HW decode support for Android PDMs using JNI calls r=jolin

Comment 4

[az [:az]]

Attachment: Bug 1809570 - Part 3 - Add per-codec SW/HW decode support info to about:support on Android r=jolin

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8b60bf251af0
Add utility functions to convert between MIME type strings and codec SW/HW support enums. r=jolin
https://hg.mozilla.org/integration/autoland/rev/bbccf0693489
Add utility functions to distinguish between SW/HW codec support on Android r=geckoview-reviewers,owlish
https://hg.mozilla.org/integration/autoland/rev/394165fce635
Request and process per-codec SW/HW decode support for Android PDMs using JNI calls r=jolin
https://hg.mozilla.org/integration/autoland/rev/849d3490fd92
Add per-codec SW/HW decode support info to about:support on Android r=jolin

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8b60bf251af0
https://hg.mozilla.org/mozilla-central/rev/bbccf0693489
https://hg.mozilla.org/mozilla-central/rev/394165fce635
https://hg.mozilla.org/mozilla-central/rev/849d3490fd92

Comment 7

[Marian-Vasile Laza]

Backed out 4 changesets (Bug 1809570) for causing *.webm reftest failures.
Backout link
Push with failures <--> R6
Failure Log

Comment 8

[Atila Butkovits]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/9c675f324f28db6ae558f589259e9780ff7a8891

Comment 9

[az [:az]]

Attachment: Bug 1809570 - Part 3 - Update test expectation for color_quads for yuv420p rendering on Android to expect a pass. r=jolin

The previous failure was due to the check for hardware decode support in
AndroidDecoderModule relying solely on gfxVars::UseVP9HwDecode(). D166239 updates
HardwareCodecCapabilityUtils to distinguish between SW/HW decode, which
is used by D166240 as an additional check in AndroidDecoderModule.
This prevents a crash and causes two previously failing tests to now pass.

Comment 10

[Phabricator Automation]

Comment on attachment 9311668 [details]
Bug 1809570 - Part 1 - Add utility functions to convert between MIME type strings and codec SW/HW support enums. r=jolin

Revision D166238 was moved to bug 1822932. Setting attachment 9311668 [details] to obsolete.

Comment 11

[Phabricator Automation]

Comment on attachment 9311669 [details]
WIP: Bug 1809570 - Add utility functions to distinguish between SW/HW codec support on Android r=jolin

Revision D166239 was moved to bug 1822932. Setting attachment 9311669 [details] to obsolete.

Comment 12

[az [:az]]

Splitting this into two bugs, as I'd like to land the utility functions first to make sure that the changes aren't contributing to intermittents.

Comment 13

[az [:az]]

Attachment: WIP: Bug 1809570 - Part 4 - Add per-codec SW/HW decode support info to about:support on Android r=jolin

Depends on D169869

Depends on D169869

Comment 14

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:az, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/91a01dde00f3
Part 1 - Add utility functions to convert between MIME type strings and codec SW/HW support enums. r=jolin
https://hg.mozilla.org/integration/autoland/rev/bb1c49774fca
Part 2 - Request and process per-codec SW/HW decode support for Android PDMs using JNI calls r=jolin
https://hg.mozilla.org/integration/autoland/rev/e64c296cce76
Part 3 - Add per-codec SW/HW decode support info to about:support on Android r=jolin

Comment 16

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/91a01dde00f3
https://hg.mozilla.org/mozilla-central/rev/bb1c49774fca
https://hg.mozilla.org/mozilla-central/rev/e64c296cce76