1809637 - Improve console error checks on toolkit search tests

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

For the toolkit search code, we have checks on our xpcshell-tests to ensure that there are no unexpected error messages reported to the console.

Unfortunately due to the way they are implemented (where they report errors as the tests proceed), it can cause infinite recursion, e.g. when currently running test_engine_selector_remote_settings.js.

We should switch to checking the logs at the end of the test, and only reporting after we've finished listening to the console.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1809637 - Improve console.error checking for search tests. r?#search-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62499f5142ce
Improve console.error checking for search tests. r=search-reviewers,daleharvey

Comment 3

[Sandor Molnar[:smolnar]]

Backed out for causing xpc failures in toolkit/components/search/tests/xpcshell/test_engine_ids.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/7196cd7a42add09656a54d9fe7b68bc062ca5bff

Push with failures

Failure log: TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/components/search/tests/xpcshell/test_engine_ids.js | test_enterprise_policy_engine_id - [test_enterprise_policy_engine_id : 1] Unexpected console message received during test

Comment 4

[Mark Banner (:standard8)]

It appears one of the errors I saw only in one test can sometimes be hit in any test. I've adapted the allow list, and filed bug 1812040 for the errors that were being added.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e0656bce00c0
Improve console.error checking for search tests. r=search-reviewers,daleharvey

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/e0656bce00c0