1809638 - Save the extension id in AddonSearchEngine's constructor rather than passing it to the init/update functions

Status: RESOLVED FIXED

(Firefox :: Search, task, P3)

Description

[Mark Banner (:standard8)]

For AddonSearchEngines we are passing the extension id to #initWithManifest and also updateFromManifest.

This is unnecessary, as we can save it in the constructor and use it appropriately.

Additionally, it will protect against inadvertently changing the extension id when upgrading the search engine.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1809638 - Save the extension id in AddonSearchEngine's constructor rather than in init(). r?#search-reviewers!

This save passing around the id in the update and init functions.

Depends on D166528

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d55613298e72
Save the extension id in AddonSearchEngine's constructor rather than in init(). r=search-reviewers,mcheang

Comment 3

[Norisz Fay [:noriszfay]]

Backed out for causing failures on test_TelemetryEnvironment_search.js

Backout link

Push with failures

Failure log

Comment 4

[Mark Banner (:standard8)]

Test fixed.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e026b8dc0ec
Save the extension id in AddonSearchEngine's constructor rather than in init(). r=search-reviewers,mcheang

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/1e026b8dc0ec