warnings in web server error log

RESOLVED FIXED in Bugzilla 2.18

Status

()

Bugzilla
Bugzilla-General
RESOLVED FIXED
15 years ago
5 years ago

People

(Reporter: myk, Assigned: bbaetz)

Tracking

2.17
Bugzilla 2.18
Bug Flags:
approval +

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

15 years ago
My web server error log is full of Bugzilla warnings.
(Assignee)

Comment 1

15 years ago
Tehres a few time-tracking related undefined value ones for process_bug which I
fixed in my Bug.pm redo (I originally had those attributes not being valid on
the Bug object if timetracking wasn't enabled, but that broke too much stuff)
(Reporter)

Comment 2

15 years ago
Created attachment 106842 [details] [diff] [review]
log of warnings and other errors, with incidence counts

Here's a log of the warnings and other errors I have seen.  "File not found"
and buglist.cgi problems that include queries have been purged.  The log file
is for the last six days (from last Wednesday afternoon, November 13) and thus
includes post-upgrade issues (and any pre-upgrade issues that weren't resolved
by the upgrade).
(Assignee)

Comment 3

15 years ago
The process_bug ones can be fixed by wrapping an |if
(UserInGroup(Param('timetracking'))| arround those blocks.

You also need to |$::FORM{dontchange} ||= "";|.

Both of those have been done in my Bug.pm rewrite, although I guess I could pull
them out for this bug

I'll do that in a couple of hours, in fact
(Assignee)

Comment 4

15 years ago
Created attachment 106851 [details] [diff] [review]
fix some warnings

Line numbers got moved arround as the various patches got applied, but here are
some fixes I could reproduce:

a) process_bug/User.pm - fix warning if dontchange wasn't set in the form
b) process_bug - don't check time tracking form vars if we're not doing time
tracking
c) showdependencygraph - don't check the open state for a non-existant (ie non
visible) bug
(Assignee)

Updated

15 years ago
Attachment #106851 - Flags: review?(myk)
(Reporter)

Comment 5

15 years ago
Comment on attachment 106851 [details] [diff] [review]
fix some warnings

r=myk
a=myk (low-risk clean-up)
Attachment #106851 - Flags: review?(myk) → review+
(Assignee)

Comment 6

15 years ago
Fixed. Leaving bug open for the other warnings.
The checkin from comment #6 has been backed out.

Whatever you did in that checkin prevents anyone not in the timetrackinggroup
from making comments on bugs.  This also means if a site doesn't use
timetracking at all, nobody can make comments.
Comment on attachment 106851 [details] [diff] [review]
fix some warnings

Removing review flag...  As stated in comment 7 this breaks commenting on bugs.
Attachment #106851 - Flags: review+ → review-
(Assignee)

Comment 9

15 years ago
"This also means if a site doesn't use timetracking at all, nobody can make
comments."

bmo doesn't use time tracking at all, and people have been able to make comments....

Ditto on all of my local trees. Let me look into this a bit....
(Assignee)

Comment 10

15 years ago
Created attachment 107084 [details] [diff] [review]
don't know why this worked the first time

I have no clue why this worked for me teh first time, and it obviously isn't on
bmo...

Try this, instead.

The additional patch is to stop the _time vars even being looked at if you're
not in the time tracking group, which not only fixes a warning, but is arguably
a security fix too... (Why aren't those vars being logged in the activity log,
btw?

I don't have time tracking enabled - can someone who does please test this?
Attachment #106851 - Attachment is obsolete: true
(Assignee)

Updated

15 years ago
Attachment #107084 - Flags: review?(bugreport)

Comment 11

15 years ago
Comment on attachment 107084 [details] [diff] [review]
don't know why this worked the first time

r=joel
Attachment #107084 - Flags: review?(bugreport) → review+
(Assignee)

Updated

15 years ago
Flags: approval?
Flags: approval? → approval+
(Assignee)

Comment 12

15 years ago
->me I'm going to close this bug; we can open new ones for new issues
Assignee: justdave → bbaetz
Target Milestone: --- → Bugzilla 2.18
(Assignee)

Comment 13

15 years ago
... and fixed
Status: NEW → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
QA Contact: matty_is_a_geek → default-qa
You need to log in before you can comment on or make changes to this bug.