1809745 - Focus speaker selection list in prompt

Status: RESOLVED FIXED

(Firefox :: Site Permissions, enhancement, P1)

Description

[Karl Tomlinson (:karlt)]

Bug 1800286 proposes including the speaker selection list in the primary permission grant prompt rather than as a secondary drop-down.
Focusing the list would enable arrow keys to select the speaker. It would also more clearly highlight which speaker will be given permission.

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: dark-focused-richlistbox.png

Compare with attachment 9311850 [details].

Comment 2

[Karl Tomlinson (:karlt)]

Attachment: Bug 1809745 focus speaker selection richlistbox in prompt r?pbz

This cannot be done during "showing" because the richlistbox does not have a
frame at that point.

As well as enabling arrow keys, focus also clearly identifies the speaker
being considered for a permission grant. Without focus, the selected item is
identified by subtle background color changes, and so the selected item would
not be clear in a list of two items.

Depends on D182318

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The following patch is waiting for review from an inactive reviewer:

ID	Title	Author	Reviewer Status
D182319	Bug 1809745 focus speaker selection richlistbox in prompt r?pbz	karlt	ayeddi: Back Jul 24, 2023

:karlt, could you please find another reviewer?

For more information, please visit BugBot documentation.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fae9c8496544
focus speaker selection richlistbox in prompt r=ayeddi

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/fae9c8496544