1809752 - Assert if GetCurrentSerialEventTarget is called on a thread pool with no active TaskQueue

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement, P2)

Description

[Nika Layzell [:nika] (ni? for response)]

This will help catch issues such as the one from bug 1806751, as we will assert earlier in the process. This also aligns better with the existing documentation of the method (which has been updated), which suggests that the method would assert if called on a thread pool.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1809752 - Part 1: Allow querying the current nsThreadPool, r=mccr8!

This was always being tracked internlly to implement
nsThreadPool::IsOnCurrentThread, however this patch exposes the getter
publicly.

This will be used to assert if GetCurrentSerialEventTarget() is called from a
threadpool thread without a TaskQueue in the next part.

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1809752 - Part 2: Assert if GetCurrentSerialEventTarget is called on a thread pool with no active TaskQueue, r=mccr8!

This will help catch issues such as the one from bug 1806751, as we will assert
earlier in the process. This also aligns better with the existing documentation
of the method (which has been updated), which suggests that the method would
assert if called on a thread pool.

Depends on D166603

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d58c799cffe
Part 1: Allow querying the current nsThreadPool, r=mccr8
https://hg.mozilla.org/integration/autoland/rev/f0d9fcfaa6f8
Part 2: Assert if GetCurrentSerialEventTarget is called on a thread pool with no active TaskQueue, r=mccr8

Comment 4

[Sandor Molnar[:smolnar]]

Backed out for causing for causing perma failures in browser/components/firefoxview/tests/browser/browser_feature_callout_position.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/0bbd4819fb46a437b424810a619a5d1c1cfa6905

Push with failures

Failure log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58e00c598375
Part 1: Allow querying the current nsThreadPool, r=mccr8
https://hg.mozilla.org/integration/autoland/rev/188ed220db1a
Part 2: Assert if GetCurrentSerialEventTarget is called on a thread pool with no active TaskQueue, r=mccr8

Comment 6

[Cosmin Sabou [:CosminS]]

Relanded this because it was not the cause of those failures.

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/58e00c598375
https://hg.mozilla.org/mozilla-central/rev/188ed220db1a